Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 748171 - dev-libs/ppl: SizeViolation issue
Summary: dev-libs/ppl: SizeViolation issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 748144
  Show dependency tree
 
Reported: 2020-10-13 06:29 UTC by Joonas Niilola
Modified: 2020-11-15 15:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2020-10-13 06:29:57 UTC
Please see the tracker bug for rationale.

  SizeViolation: 'files/disable-boeing-tests.patch' exceeds 20k in size; 21.0 KiB total
Comment 1 Michael Orlitzky gentoo-dev 2020-10-14 15:07:57 UTC
The existing fatal error cutoff in repoman is at 60KiB, and the devmanual says "any files bigger than 20KB-or-so should go to the mirrors."

I guess I don't mind if you want to make the pkgcheck fatal as well, but what benefit is there to me deleting this patch, uploading it to my dev space, and updating the ebuild right now? Everyone has already downloaded the 20KiB+ patches in the tree, so there's no benefit that I can see. Why not make it fatal *from now on* and ignore the existing violations?

Aside: 20KiB is relatively small these days, contrasted with the benefits of having things in version control and not having to worry about whose website some critical patch is stored (unversioned) on.
Comment 2 Joonas Niilola gentoo-dev 2020-10-14 15:34:57 UTC
Imagine coming home and finding it cleaner than when you left it.

But apparently I'm one of the maintainers for this package, I'll finish this and anything where maintainer didn't bother responding after 30 days.
Comment 3 Michael Orlitzky gentoo-dev 2020-10-14 16:09:49 UTC
I'm not trying to give you a hard time, just save you some effort on a problem that is capable of resolving itself. If you don't want to see pkgcheck errors in the meantime, why not drop the repoman fatal limit to 20KiB? Then you can go drink margaritas for a few months, and come back to a tree with no large patches.
Comment 4 Joonas Niilola gentoo-dev 2020-10-14 16:29:21 UTC
Sorry, I indeed interpreted it as "too much work for too little gain". I'll pursue updating repoman in parallel, too. Thanks!
Comment 5 Larry the Git Cow gentoo-dev 2020-11-15 15:31:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0bb5e7b1fdbd2a802130b9e257b6de16f6adae08

commit 0bb5e7b1fdbd2a802130b9e257b6de16f6adae08
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2020-11-15 15:05:19 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-15 15:31:21 +0000

    dev-libs/ppl: fix SizeViolation issue
    
    Closes: https://bugs.gentoo.org/748171
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/ppl/Manifest                         |    1 +
 dev-libs/ppl/files/disable-boeing-tests.patch | 1176 -------------------------
 dev-libs/ppl/ppl-1.2-r3.ebuild                |    5 +-
 3 files changed, 4 insertions(+), 1178 deletions(-)