Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 747904 - dev-lang/luajit: ~arm64 keywordreq
Summary: dev-lang/luajit: ~arm64 keywordreq
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: CC-ARCHES, KEYWORDREQ
Depends on:
Blocks: 728712 742701
  Show dependency tree
 
Reported: 2020-10-11 22:48 UTC by Conrad Kostecki
Modified: 2020-12-23 20:00 UTC (History)
0 users

See Also:
Package list:
dev-lang/luajit-2.1.0_beta3-r1 ~arm64
Runtime testing required: No
nattka: sanity-check-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Kostecki gentoo-dev 2020-10-11 22:48:23 UTC
Could we add ~arm64 keyword for dev-lang/luajit-2.0.5-r2?
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-11 22:54:11 UTC
You've picked a scary one!

We can't keyword 2.0.5-r2, but we could keyword 2.1.0_beta3-r1 just for arm64. They didn't add JIT support for this arch until some time in the betas.

Unfortunately, it's been sitting in beta for *years*. Someone asked for a release lately: https://github.com/LuaJIT/LuaJIT/issues/563.

We'd also need to unmask USE=luajit, but we should stable-mask it just to emphasise how broken it could be, even if people want to use luajit experimentally:

># Mart Raudsepp <leio@gentoo.org> (2019-01-07)
># Does not work on arm64 until dev-lang/luajit-2.1
># https://github.com/LuaJIT/LuaJIT/issues/26
>luajit

But I agree this is worth trying because luajit is useful. So let's go for the beta, and see if tests pass?
Comment 2 Larry the Git Cow gentoo-dev 2020-10-24 11:49:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=acab4934262b53a964307071942098b7caab8528

commit acab4934262b53a964307071942098b7caab8528
Author:     Rafael Martins <rafaelmartins@gentoo.org>
AuthorDate: 2020-10-24 11:48:07 +0000
Commit:     Rafael Martins <rafaelmartins@gentoo.org>
CommitDate: 2020-10-24 11:48:50 +0000

    dev-lang/luajit: add ~arm64 keyword
    
    2.1.0_beta3 is the first version including arm64 support.
    
    Bug: https://bugs.gentoo.org/747904
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Rafael Martins <rafaelmartins@gentoo.org>

 dev-lang/luajit/luajit-2.1.0_beta3-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-27 15:39:37 UTC
Left open for us to make profile changes for now
Comment 4 NATTkA bot gentoo-dev 2020-12-14 01:25:01 UTC Comment hidden (obsolete)
Comment 5 NATTkA bot gentoo-dev 2020-12-14 01:28:57 UTC Comment hidden (obsolete)
Comment 6 NATTkA bot gentoo-dev 2020-12-23 20:00:57 UTC
Unable to check for sanity:

> no match for package: dev-lang/luajit-2.1.0_beta3-r1
Comment 7 Larry the Git Cow gentoo-dev 2020-12-23 20:00:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d977a764168bcab41a2a6587d65e41e914c23f1

commit 0d977a764168bcab41a2a6587d65e41e914c23f1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-12-23 19:58:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-12-23 19:58:13 +0000

    profiles/arch/arm64: unmask luajit
    
    Closes: https://bugs.gentoo.org/747904
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/arm64/package.use.force | 4 ----
 profiles/arch/arm64/package.use.mask  | 9 ---------
 profiles/arch/arm64/use.mask          | 7 -------
 profiles/arch/arm64/use.stable.mask   | 6 ++++++
 4 files changed, 6 insertions(+), 20 deletions(-)