Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 747559 - media-gfx/xfig-3.2.7b fails to compile
Summary: media-gfx/xfig-3.2.7b fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: CVE-2019-14275, CVE-2019-19797
  Show dependency tree
 
Reported: 2020-10-10 13:22 UTC by Agostino Sarubbo
Modified: 2020-10-12 18:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,44.27 KB, text/plain)
2020-10-10 13:22 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-10-10 13:22:29 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/xfig-3.2.7b fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2020-10-10 13:22:32 UTC
Created attachment 664516 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-10-10 13:22:33 UTC
Possible context of error(s):

sh: gs: command not found
w_icons.c:3242:31: error: ‘spl_bckgnd_width’ undeclared here (not in a function); did you mean ‘spl_bckgnd_ic’?
Comment 3 Jakov Smolić archtester gentoo-dev 2020-10-10 17:59:08 UTC
I was able to reproduce this only after removing app-text/ghostscript-gpl from my system. 
`--without-gs` is passed to configure, but `gs` is called nevertheless.

Ticket is opened upstream at https://sourceforge.net/p/mcj/tickets/109/
Comment 4 Jakov Smolić archtester gentoo-dev 2020-10-10 18:14:47 UTC
`--without-gs` configure option was removed in https://sourceforge.net/p/mcj/xfig/ci/7ae9e72410667275eedce25da8b6930db69d63cf/
hinting that perhaps the ebuild could/should depend on app-text/ghostscript-gpl unconditionally?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-11 15:10:30 UTC
(In reply to Jakov Smolić from comment #4)
> `--without-gs` configure option was removed in
> https://sourceforge.net/p/mcj/xfig/ci/
> 7ae9e72410667275eedce25da8b6930db69d63cf/
> hinting that perhaps the ebuild could/should depend on
> app-text/ghostscript-gpl unconditionally?

"If it is desired to not use ghostscript, the X resources Fig.ghostscript and
Fig.gslib should be set to emtpy strings, or xfig called with the options
-ghostscript "" -gslib ""."

So yeah, we're kind of stuck with it. We could make it an optfeature or something but this is just going to confuse people, IMO.
Comment 6 Larry the Git Cow gentoo-dev 2020-10-12 18:26:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d760b499a6081410e6125dae00c236d5404a60a1

commit d760b499a6081410e6125dae00c236d5404a60a1
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-10-12 06:04:17 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2020-10-12 18:26:07 +0000

    media-gfx/xfig: patch ghostscript issue
    
    Closes: https://bugs.gentoo.org/747559
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Closes: https://github.com/gentoo/gentoo/pull/17891
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 media-gfx/xfig/files/xfig-3.2.7b-ghostscript.patch | 13 +++++++++++++
 media-gfx/xfig/xfig-3.2.7b.ebuild                  |  1 +
 2 files changed, 14 insertions(+)