Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744565 - net-analyzer/mtr-0.94 IUSE defaults changed
Summary: net-analyzer/mtr-0.94 IUSE defaults changed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-24 21:57 UTC by Joshua Kinard
Modified: 2020-10-05 02:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard gentoo-dev 2020-09-24 21:57:32 UTC
It looks like in net-analyzer/mtr-0.94.ebuild, the IUSE variable was updated to default all supported USE flags to on.  This introduces unnecessary dependencies, especially on systems that are headless and don't run X11, and will surprise anyone who already has mtr installed with the old defaults.

net-analyzer/mtr/mtr-0.93-r2.ebuild:
IUSE="gtk ipv6 ncurses"

net-analyzer/mtr/mtr-0.94.ebuild:
IUSE="+gtk +ipinfo +ipv6 +jansson +ncurses"

I recommend removing the '+' character from the IUSE values to restore the default behavior from 0.93-r2.  Users can enable needed functionality themselves via package.use.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-25 08:42:11 UTC
This was an intentional change to follow upstream defaults. That's what IUSE defaults are for. Anyone running a headless/minimal/embedded system is perfectly capable of making those changes in local profiles, and I don't consider "surprise" to be a valid reason to not tweak the defaults to comply with upstream defaults.
Comment 2 Ionen Wolkens gentoo-dev 2020-09-25 15:55:10 UTC
USE=gtk is already default for desktop profiles though, it doesn't make much sense to be enabled on others.
Comment 3 Ionen Wolkens gentoo-dev 2020-09-25 16:02:09 UTC
Also it's not upstream defaults, it's an automagic dep. If I take this source on my box without gtk then it'll build without gtk with default flags.
Comment 4 Minung Kuo 2020-10-01 14:12:55 UTC
I try to install 0.94 version mtr on my no-GUI system, but all USE flags are used automatically, so portage tell me need to install almost 100 dependicies.

I think Kinard's advice is right.
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2020-10-01 20:04:21 UTC
While it is one thing and normally correct to follow upstream's default with IUSE, this is a little bit crazy for a package you will mostly find on servers to debug network issues...
Comment 6 Larry the Git Cow gentoo-dev 2020-10-04 07:17:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb9c7e4e862336621c5a1463e3f42c6231912f3b

commit bb9c7e4e862336621c5a1463e3f42c6231912f3b
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-10-04 07:15:30 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-10-04 07:17:26 +0000

    net-analyzer/mtr: Invert USE defaults that pull in more deps
    
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=744565
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-analyzer/mtr/mtr-0.94.ebuild | 2 +-
 net-analyzer/mtr/mtr-9999.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 7 Joshua Kinard gentoo-dev 2020-10-05 02:26:31 UTC
Marking RESOLVED::FIXED, as the recent commit should resolve this.