Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744484 - net-analyzer/fragroute depends on dev-libs/libdnet[ipv6]
Summary: net-analyzer/fragroute depends on dev-libs/libdnet[ipv6]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords: CC-ARCHES, STABLEREQ
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2020-09-24 08:23 UTC by Konrad Karczewski
Modified: 2020-11-02 08:22 UTC (History)
3 users (show)

See Also:
Package list:
net-analyzer/fragroute-1.2.6-r4 amd64 x86
Runtime testing required: ---
nattka: sanity-check+


Attachments
new libdnet-1.14 ebuild (libdnet-1.14.ebuild,1.51 KB, text/plain)
2020-09-24 09:21 UTC, Konrad Karczewski
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Karczewski 2020-09-24 08:23:57 UTC
Upgrade to dev-libs/libdnet-1.14 is blocked due to lack of ipv6 flag, which is needed for fragroute:

# emerge -pv dev-libs/libdnet

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] dev-libs/libdnet-1.12::gentoo  USE="ipv6 -python -static-libs -test" PYTHON_TARGETS="python2_7" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

WARNING: One or more updates/rebuilds have been skipped due to a dependency conflict:

dev-libs/libdnet:0

  (dev-libs/libdnet-1.14:0/0::gentoo, ebuild scheduled for merge) USE="-python -static-libs -test" ABI_X86="(64)" PYTHON_TARGETS="python3_7 -python3_6 -python3_8" conflicts with
    >=dev-libs/libdnet-1.12[ipv6] required by (net-analyzer/fragroute-1.2.6-r3:0/0::gentoo, installed) USE="" ABI_X86="(64)"
                            ^^^^ 

The ipv6 flag in dev-libs/libdnet-1.12 used the following patch:

ipv6? ( https://fragroute-ipv6.googlecode.com/files/${P}.ipv6-1.patch.gz )"

This URL is no longer valid, but the equivalent is:

https://github.com/stsi/fragroute-ipv6/blob/master/libdnet-ng-ipv6.patch

it explicitly mentions the new dev-libs/libdnet location (https://github.com/ofalk/libdnet), so it seems to be adjusted for the latest version.

Please note that both of these patches come from fragroute, which moved from googlecode to github in the meanwhile.

Reproducible: Always
Comment 1 Konrad Karczewski 2020-09-24 09:21:37 UTC
Created attachment 662275 [details]
new libdnet-1.14 ebuild

The attached ebuild restores the ipv6 flag, and both libdnet-1.14 and net-analyzer/fragroute-1.2.6-r3 build correctly with it in place. I didn't test fragroute to any extend, but since the creator is the provider of this libdnet patch I assume it works OK.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-24 09:51:35 UTC
Comment on attachment 662275 [details]
new libdnet-1.14 ebuild

Not going to do that. Upstream for libdnet needs to implement these changes officially to expose the new API features.

As you can see from the See alsos, this process was set in motion some time ago, and the new API features have been implemented but not yet released. If you want to actually help, then you will need to ask libdnet developers to release a new version with those changes.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-26 10:08:04 UTC
(In reply to Jeroen Roovers from comment #2)
> Comment on attachment 662275 [details]
> new libdnet-1.14 ebuild
> 
> Not going to do that. Upstream for libdnet needs to implement these changes
> officially to expose the new API features.
> 
> As you can see from the See alsos, this process was set in motion some time
> ago, and the new API features have been implemented but not yet released. If
> you want to actually help, then you will need to ask libdnet developers to
> release a new version with those changes.

For context, libdnet development was in limbo for years, so the previous addition of the "ndisc/ipv6" patch from the fragroute authors seemed fine. With recent changes in the life of libdnet, however, adding patches in that way is not ideal. For instance, the "ndisc" addition to the previously added IPv6 support should be accompanied with a libtool version/SONAME change[0], as the users of libdnet should be able to find out whether it supports the new feature.


[0] https://github.com/ofalk/libdnet/commit/1c324828f4c6c64c9340f169bc059152dba1f998#r42743515
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-27 04:28:27 UTC
I suppose this means that fragroute is on its way out.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-27 09:28:58 UTC
(In reply to Michał Górny from comment #4)
> I suppose this means that fragroute is on its way out.

No, it does not.
Comment 6 Larry the Git Cow gentoo-dev 2020-09-27 10:06:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f299f49c951d680113412807a38a90c5024aba57

commit f299f49c951d680113412807a38a90c5024aba57
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-09-27 10:06:06 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-09-27 10:06:56 +0000

    net-analyzer/fragroute: Depend on >=dev-libs/libdnet-1.14-r1
    
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Bug: https://bugs.gentoo.org/744484
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-analyzer/fragroute/fragroute-1.2.6-r4.ebuild | 54 ++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af1632be53234f09ff25a70576f4f98a782d405a

commit af1632be53234f09ff25a70576f4f98a782d405a
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-09-27 10:02:00 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-09-27 10:06:54 +0000

    dev-libs/libdnet: Add ndisc patch
    
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Bug: https://bugs.gentoo.org/744484
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 dev-libs/libdnet/files/libdnet-1.14-ndisc.patch | 796 ++++++++++++++++++++++++
 dev-libs/libdnet/libdnet-1.14-r1.ebuild         |  78 +++
 2 files changed, 874 insertions(+)
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-27 10:10:39 UTC
Since the ndisc feature in libdnet is used solely by fragroute, I decided that as long as the in-tree usage is consistent, there should be no need to wait for libdnet upstream to release a new version with the API changes.
Comment 8 NATTkA bot gentoo-dev 2020-10-24 13:44:51 UTC Comment hidden (obsolete)
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-02 08:22:28 UTC
amd64 done

all arches done