Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744445 - dev-libs/libtpms-0.7.3 uses -Werror for build
Summary: dev-libs/libtpms-0.7.3 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christopher Byrne
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-09-24 06:07 UTC by Agostino Sarubbo
Modified: 2020-10-08 06:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-24 06:07:32 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/libtpms-0.7.3 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2020-10-08 06:57:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6ddcb72a8738fc10d1cbf3812d4764bbe2db009

commit e6ddcb72a8738fc10d1cbf3812d4764bbe2db009
Author:     Salah Coronya <salah.coronya@gmail.com>
AuthorDate: 2020-09-24 19:28:15 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-10-08 06:48:32 +0000

    dev-libs/libtpms: Remove -WError
    
    Closes: https://bugs.gentoo.org/744445
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/17654
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/libtpms/files/libtpms-0.7.3-Remove-WError.patch | 13 +++++++++++++
 dev-libs/libtpms/libtpms-0.7.3.ebuild                    |  4 ++++
 2 files changed, 17 insertions(+)