Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 737970 - mail-filter/libmilter-1.0.2_p1: sendmail-8.14.6-build-system.patch fails to apply
Summary: mail-filter/libmilter-1.0.2_p1: sendmail-8.14.6-build-system.patch fails to a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sam James
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 730890
  Show dependency tree
 
Reported: 2020-08-19 04:50 UTC by Agostino Sarubbo
Modified: 2020-08-29 00:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,6.69 KB, text/plain)
2020-08-19 04:50 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-08-19 04:50:55 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: mail-filter/libmilter-1.0.2_p1 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GLIBC-2.32. If you think that this issue is strictly related to GLIBC please block bug 736174.
Comment 1 Agostino Sarubbo gentoo-dev 2020-08-19 04:50:57 UTC
Created attachment 655446 [details]
build.log

build log and emerge --info
Comment 2 Craig Andrews gentoo-dev 2020-08-19 14:46:12 UTC
>>> Unpacking source...
>>> Unpacking sendmail.8.15.2.tar.gz to /var/tmp/portage/mail-filter/libmilter-1.0.2_p1/work
>>> Source unpacked in /var/tmp/portage/mail-filter/libmilter-1.0.2_p1/work
>>> Preparing source in /var/tmp/portage/mail-filter/libmilter-1.0.2_p1/work/sendmail-8.15.2 ...
 * Applying sendmail-8.14.6-build-system.patch ...
patching file cf/cf/Makefile
patching file devtools/M4/UNIX/defines.m4
patching file devtools/M4/UNIX/executable.m4
patching file devtools/M4/UNIX/library.m4
patching file devtools/M4/UNIX/manpage.m4
patching file libmilter/Makefile.m4
patching file mail.local/Makefile.m4
patching file rmail/Makefile.m4
patching file sendmail/Makefile.m4
Hunk #1 FAILED at 43.
1 out of 1 hunk FAILED -- saving rejects to file sendmail/Makefile.m4.rej
 [ !! ]
 * ERROR: mail-filter/libmilter-1.0.2_p1::gentoo failed (prepare phase):
 *   patch -p1  failed with /var/tmp/portage/mail-filter/libmilter-1.0.2_p1/files/sendmail-8.14.6-build-system.patch
Comment 3 Craig Andrews gentoo-dev 2020-08-19 14:46:44 UTC
Problem introduced in this commit https://github.com/gentoo/gentoo/commit/6c80a732e905607c72d563ad84cf66762eb40e2f made by bman@gentoo.org and sam@gentoo.org
Comment 4 Larry the Git Cow gentoo-dev 2020-08-19 14:49:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c79f0113757f21b8eb3dc945658358d90e21415b

commit c79f0113757f21b8eb3dc945658358d90e21415b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-08-19 14:49:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-08-19 14:49:20 +0000

    mail-filter/libmilter: fix patch path
    
    This issue was fixed for sendmail, but I hadn't realised
    the same error had been made for libmilter.
    
    Closes: https://bugs.gentoo.org/737970
    Package-Manager: Portage-3.0.3, Repoman-3.0.0
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/sendmail-8.14.6-build-system.patch       |  73 ++++++++--
 .../files/sendmail-8.16.1-build-system.patch       | 158 +++++++++++++++++++++
 mail-filter/libmilter/libmilter-1.0.2_p1-r1.ebuild |   2 +-
 3 files changed, 222 insertions(+), 11 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-19 14:50:14 UTC
(In reply to Craig Andrews from comment #3)
> Problem introduced in this commit
> https://github.com/gentoo/gentoo/commit/
> 6c80a732e905607c72d563ad84cf66762eb40e2f made by bman@gentoo.org and
> sam@gentoo.org

Yep. I hadn't realised when I reviewed the ebuild that the same patch file was going to be modified in place. I've fixed the path for now by restoring the old patch and changing the new (unkeyworded) libmilter to use the newer one.