Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 736968 - media-sound/elisa-20.04.3 enables gstreamer silently
Summary: media-sound/elisa-20.04.3 enables gstreamer silently
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
Depends on:
Reported: 2020-08-13 10:36 UTC by kavol
Modified: 2020-08-13 17:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Note You need to log in before you can comment on or make changes to this bug.
Description kavol 2020-08-13 10:36:42 UTC

wondering why my KDE installation wants to pull in some strange stuff, I have traced one of the problems to media-sound/elisa

despite I have USE gstreamer disabled, it wants to recompile qtmedia with gstreamer support and pull it in

looking into the ebuild, I have found the culprit in DEPEND:

vlc? ( media-video/vlc:= )
!vlc? ( >=dev-qt/qtmultimedia-${QTMIN}:5[gstreamer] )

and since I have USE vlc disabled, it defaults to gstreamer, despite I have it disabled too

- now this is pretty unfortunate, because if I would really have to choose between these two, I would choose vlc, and making such decision silently behind the back of the user goes against the spirit of Gentoo

I believe better solution would be like this:

REQUIRED_USE="|| ( gstreamer vlc )"
    gstreamer? ( >=dev-qt/qtmultimedia-${QTMIN}:5[gstreamer] )
    vlc? ( media-video/vlc:= )

and, possibly, decide also on kdemultimedia-meta level:

    gstreamer? (
    vlc? ( >=media-sound/elisa-${PV}:${SLOT} )

- which would be the best, IMHO, because it doesn't force that unstable stuff on happy users of mplayer or ffmpeg backed software; it would just follow the logic already applied to kde-apps/kamoso
Comment 1 Andreas Sturmlechner gentoo-dev 2020-08-13 15:56:13 UTC
It only does that because you set IUSE="-vlc" on elisa.
Comment 2 kavol 2020-08-13 16:45:19 UTC
(In reply to Andreas Sturmlechner from comment #1)
> It only does that because you set IUSE="-vlc" on elisa.

not "IUSE on elisa" but global USE, but generally yes, that's what I have said in the fourth sentence

however, following to the next one I'm trying to explain why I consider this a problem which is worth reporting as a bug

if you do not agree, instead of simply stating the obvious what it does now, it would be very nice of you providing an explanation why the current behaviour is the best that can be achieved, and what is bad about my proposal how to handle things (that looks from my, the user, point of view way better than the current situation), before closing the bug

that way it can be used for further reference, such as a basis for adjusting the dependency for kamoso, because it doesn't make sense to omit it based on gstreamer apparent absence when it is forced to be present anyways
Comment 3 Andreas Sturmlechner gentoo-dev 2020-08-13 16:53:32 UTC
We don't add more bureaucracy just so you can control everything with a single make.conf file globally. "vlc" is a *local* use flag, and the ebuild default works out of the box per upstream's recommendations.

REQUIRED_USE constraints are painful for users and must be avoided when possible.

The kdemultimedia-meta ebuild provides IUSE=gstreamer for dependencies where it is unconditional (like kamoso).
Comment 4 Andreas Sturmlechner gentoo-dev 2020-08-13 17:00:43 UTC
This was actually improved with 20.04.3 to not by default require qtmultimedia[gstreamer]:
Comment 5 Andreas Sturmlechner gentoo-dev 2020-08-13 17:21:29 UTC
Of course, you could suggest inverting the logic here and replace IUSE="+vlc" with IUSE="gstreamer". Then, however, because "gstreamer" is enabled globally in gnome profile the ebuild would deviate from the recommended default for those users. And you would probably raise a bug about elisa 'enabling' vlc 'silently'.