NOTE: this is a build log with dev-util/pkgconfig-0.28-r2 present. cat /var/tmp/portage/dev-libs/libxslt-1.1.34/temp/autoconf.out ***** autoconf ***** ***** PWD: /var/tmp/portage/dev-libs/libxslt-1.1.34/work/libxslt-1.1.34 ***** autoconf --force configure.ac:486: error: possibly undefined macro: PKG_CHECK_MODULES_STATIC If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. build log: libxslt-1.1.34: * Package: dev-libs/libxslt-1.1.34 Load avg: 3.11, 2.13, 2.86 libxslt-1.1.34: * Repository: portage-stable libxslt-1.1.34: * Maintainer: gnome@gentoo.org libxslt-1.1.34: * USE: abi_x86_64 amd64 crypt elibc_glibc kernel_linux python python_targets_python2_7 userland_GNU libxslt-1.1.34: * FEATURES: network-sandbox sandbox userpriv usersandbox libxslt-1.1.34: * Running stacked hooks for pre_pkg_setup libxslt-1.1.34: * sysroot_build_bin_dir ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: * Running stacked hooks for post_pkg_setup libxslt-1.1.34: * python_eclass_hack ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: 10:00:31 >>> Unpacking source... libxslt-1.1.34: 10:00:31 >>> Unpacking libxslt-1.1.34.tar.gz to /var/tmp/portage/dev-libs/libxslt-1.1.34/work libxslt-1.1.34: 10:00:32 >>> Source unpacked in /var/tmp/portage/dev-libs/libxslt-1.1.34/work libxslt-1.1.34: * Running stacked hooks for post_src_unpack libxslt-1.1.34: * asan_init ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: * Running stacked hooks for pre_src_prepare libxslt-1.1.34: * build_toolchain_catch ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: 10:00:32 >>> Preparing source in /var/tmp/portage/dev-libs/libxslt-1.1.34/work/libxslt-1.1.34 ... libxslt-1.1.34: * Applying libxslt-1.1.34-simplify-python.patch ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: * Applying libxslt-1.1.28-disable-static-modules.patch ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: * Running eautoreconf in '/var/tmp/portage/dev-libs/libxslt-1.1.34/work/libxslt-1.1.34' ... libxslt-1.1.34: * Running libtoolize --install --copy --force --automake ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: * Running aclocal ... libxslt-1.1.34: [ ok ] libxslt-1.1.34: * Running autoconf --force ... libxslt-1.1.34: [ !! ] libxslt-1.1.34: libxslt-1.1.34: * Failed Running autoconf ! libxslt-1.1.34: * libxslt-1.1.34: * Include in your bugreport the contents of: libxslt-1.1.34: * libxslt-1.1.34: * /var/tmp/portage/dev-libs/libxslt-1.1.34/temp/autoconf.out libxslt-1.1.34: libxslt-1.1.34: * ERROR: dev-libs/libxslt-1.1.34::portage-stable failed (prepare phase): libxslt-1.1.34: * Failed Running autoconf ! libxslt-1.1.34: * libxslt-1.1.34: * Call stack: libxslt-1.1.34: * ebuild.sh, line 125: Called src_prepare libxslt-1.1.34: * environment, line 3552: Called eautoreconf libxslt-1.1.34: * environment, line 1458: Called eautoconf '--force' libxslt-1.1.34: * environment, line 1371: Called autotools_run_tool '--at-m4flags' 'autoconf' '--force' libxslt-1.1.34: * environment, line 786: Called die libxslt-1.1.34: * The specific snippet of code: libxslt-1.1.34: * die "Failed Running $1 !"; libxslt-1.1.34: * libxslt-1.1.34: * Build log: /var/log/portage/dev-libs:libxslt-1.1.34:20200803-170031.log libxslt-1.1.34: * Stable log symlink: /var/tmp/portage/dev-libs/libxslt-1.1.34/temp/build.log libxslt-1.1.34: * CWD: /var/tmp/portage/dev-libs/libxslt-1.1.34/work/libxslt-1.1.34 libxslt-1.1.34: * S: /var/tmp/portage/dev-libs/libxslt-1.1.34/work/libxslt-1.1.34
I am working on a pull request for this here: https://github.com/gentoo/gentoo/pull/16976 I need to update the commit message, but I figured I would comment in the mean time.
CCing virtual/pkgconfig maintainers - we may want a verbump there to a version that ensures the presence of that macro in the m4 files provided, to be able to depend as needed, instead of soft blocking things
Sure, whatever works best.
Yes, a bump of virtual/pkgconfig makes more sense here.
virtual/pkgconfig-2 already depends on >=dev-util/pkgconfig-0.29.2, which should supply the needed PKG_CHECK_MODULES_STATIC macro.
So setting DEPEND="virtual/pkgconfig" should be enough?
(In reply to allenwebb from comment #6) > So setting DEPEND="virtual/pkgconfig" should be enough? In EAPI 6, DEPEND="virtual/pkgconfig" should suffice. In EAPI 7, it should be BDEPEND="virtual/pkgconfig".
Actually, make it ">=virtual/pkgconfig-1". Earlier versions had ">=dev-util/pkgconfig-0.28-r1" as the dependency.
virtual/pkgconfig-1 has it as well, as v2 was just to drop the MULTILIB_USEDEP stuff. pkgconf-1.3.1 seems to be the first version that has this pkg.m4 synced in. So in conclusion, this is really just about missing a virtual/pkgconfig build depend. This appears missing from the previous libxslt version too, while actually needed for libxml2 check. Even older versions probably had autotools code to fallback to manual libs stuff when pkg-config wasn't present. There are ways to avoid needing it at buildtime (if we didn't eautoreconf), but we don't use them. If we did, we could copy in pkg.m4 from pkg-config tarballs or otherwise (some packages like glib used to have to do that, to avoid a cyclic dep).
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61cb3f7f415df49e84a45b1f9803d15378e1d3da commit 61cb3f7f415df49e84a45b1f9803d15378e1d3da Author: Sam James <sam@gentoo.org> AuthorDate: 2020-08-05 04:54:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2020-08-06 16:46:12 +0000 dev-libs/libxslt: add pkgconfig dependency Add as DEPEND for now, as we're going to bump to EAPI 7 shortly. Closes: https://bugs.gentoo.org/735798 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/libxslt/libxslt-1.1.33-r1.ebuild | 8 ++++++-- dev-libs/libxslt/libxslt-1.1.34.ebuild | 5 ++++- 2 files changed, 10 insertions(+), 3 deletions(-)
