Please port the package to use python-any-r1 and support py3.
ping.
Created attachment 663892 [details] ebuild with proposed PYTHON_COMPAT variable ebuild with the proposed changes from https://dev.gentoo.org/~mgorny/python-guide/buildsys.html#scons
here is an ebuild with the suggestions from https://dev.gentoo.org/~mgorny/python-guide/buildsys.html#scons It builds (and plays) fine for version 0.9.12 .
But I would like to propose a different ebuild without the PYTHON_COMPAT variable. Me thinks this variable has to be adopted every time the major and minor python version changes. So here is another ebuild using the SCONS_MIN_VERSION="3.0.1-r100" which - according to the documentation - uses at least python-3 and no python-2 any more. These are the differences between the two: --- /usr/local/portage/games-strategy/endless-sky/endless-sky-0.9.12.ebuild 2020-10-05 16:42:36.149540612 +0200 +++ endless-sky-0.9.12.ebuild 2020-10-05 18:11:14.755618495 +0200 @@ -3,8 +3,7 @@ EAPI=7 -PYTHON_COMPAT=( python3_{6,7,8,9} ) -inherit eutils gnome2-utils python-any-r1 scons-utils +inherit eutils gnome2-utils scons-utils DESCRIPTION="Space exploration, trading & combat in the tradition of Terminal Velocity" HOMEPAGE="https://endless-sky.github.io" @@ -13,7 +12,7 @@ LICENSE="CC-BY-SA-4.0 CC-BY-SA-3.0 GPL-3+ public-domain" SLOT="0" KEYWORDS="~amd64 ~x86" - +SCONS_MIN_VERSION="3.0.1-r100" RDEPEND="media-libs/glew:0 media-libs/libsdl2
Created attachment 663898 [details] ebuild using the variable SCONS_MIN_VERSION
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee37d7d06147adce4a48093705ec8cfba1eb350e commit ee37d7d06147adce4a48093705ec8cfba1eb350e Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2020-10-26 07:30:25 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2020-10-26 07:38:57 +0000 games-strategy/endless-sky: Remove last-rited pkg Closes: https://bugs.gentoo.org/735542 Signed-off-by: Michał Górny <mgorny@gentoo.org> games-strategy/endless-sky/Manifest | 1 - .../endless-sky/endless-sky-0.9.6.ebuild | 55 ---------------------- games-strategy/endless-sky/metadata.xml | 14 ------ profiles/package.mask | 1 - 4 files changed, 71 deletions(-)
That doesn't really solve it, that just removes the package :/ . Furthermore, using "ebuild with proposed PYTHON_COMPAT variable", renaming to work for version 0.9.14, and adding Python 3.10 to the PYTHON_COMPAT list since Python 3.10 is stable now, WORKS! Why was this removed?? The proposed fix is completely functional, yet it was never merged!
(In reply to 27 from comment #7) > That doesn't really solve it, that just removes the package :/ . > > Furthermore, using "ebuild with proposed PYTHON_COMPAT variable", renaming > to work for version 0.9.14, and adding Python 3.10 to the PYTHON_COMPAT list > since Python 3.10 is stable now, WORKS! Why was this removed?? The proposed > fix is completely functional, yet it was never merged! Because the maintainer never did it and nobody noticed your comment. Feel free to attach a git am-able patch (use 'git format-patch') for us to restore it at the latest version?
(In reply to Sam James from comment #8) > (In reply to 27 from comment #7) > > That doesn't really solve it, that just removes the package :/ . > > > > Furthermore, using "ebuild with proposed PYTHON_COMPAT variable", renaming > > to work for version 0.9.14, and adding Python 3.10 to the PYTHON_COMPAT list > > since Python 3.10 is stable now, WORKS! Why was this removed?? The proposed > > fix is completely functional, yet it was never merged! > > Because the maintainer never did it and nobody noticed your comment. > > Feel free to attach a git am-able patch (use 'git format-patch') for us to > restore it at the latest version? (While I think this is true, I do sympathise: porting to newer Scons if it's done upstream _should_ be easy, so I'll give it a go now.)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=72aa2845bba14a3291d5c73d178278a448e11d7f commit 72aa2845bba14a3291d5c73d178278a448e11d7f Author: Sam James <sam@gentoo.org> AuthorDate: 2022-01-06 23:06:22 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-01-06 23:06:32 +0000 games-strategy/endless-sky: initial import (restore at 0.9.14) Closes: https://bugs.gentoo.org/735542 Signed-off-by: Sam James <sam@gentoo.org> games-strategy/endless-sky/Manifest | 1 + .../endless-sky/endless-sky-0.9.14.ebuild | 59 ++++++++++++++++++++++ .../files/endless-sky-0.9.14-no-games-path.patch | 42 +++++++++++++++ .../files/endless-sky-0.9.14-respect-cflags.patch | 20 ++++++++ games-strategy/endless-sky/metadata.xml | 16 ++++++ 5 files changed, 138 insertions(+)
