Please port to py3.
ping.
This is a C++ program. It does not use or require python...
(In reply to Simson from comment #2) > This is a C++ program. It does not use or require python... That is incorrect: # scanelf -n `qlist -eo tcpflow` TYPE NEEDED FILE ET_DYN libpython2.7.so.1.0,libhttp_parser.so.2.9,libcap-ng.so.0,libpcap.so.1,libcairo.so.2,libsqlite3.so.0,libcrypto.so.1.1,libz.so.1,libstdc++.so.6,libm.so.6
Created attachment 662641 [details] Version bump without python eclass 1.5.2-r1 ebuild inherits python-single-r1 Could it be just dropped from ebuild? I've tried to build without this python stuff and it worked well.
Apparently autotools usage is only required in so far as that no configuration mechanism in the cmake files generates config.h.in, but cmake nevertheless expects it. So we'd need to run autotools src_configure() to generate config.h.in and then have cmake take over in src_compile().
(In reply to Michael Perlov from comment #4) > Created attachment 662641 [details] > Version bump without python eclass > > 1.5.2-r1 ebuild inherits python-single-r1 > > Could it be just dropped from ebuild? No. >I've tried to build without this > python stuff and it worked well. Because you still had python2 installed.
(In reply to Jeroen Roovers from comment #5) cmake also expects a local (bundled) copy of http-parser.
My error! Apparently there is now a module that links with python2. We will remove it.
Okay, I just pushed a tcpflow 1.6.0 which removes scan_python. I have not made a new release, however. I want to get GitHub Actions reporting no errors first. However, it compiles on my Mac and it should compile on your system.
(In reply to Jeroen Roovers from comment #7) > (In reply to Jeroen Roovers from comment #5) > > cmake also expects a local (bundled) copy of http-parser. Is there a problem with this?
(In reply to Simson from comment #10) > (In reply to Jeroen Roovers from comment #7) > > (In reply to Jeroen Roovers from comment #5) > > > > cmake also expects a local (bundled) copy of http-parser. > > Is there a problem with this? Well, it complicates the (e)build script and it pulls in more dependencies, that's all.
(In reply to Jeroen Roovers from comment #11) > (In reply to Simson from comment #10) > > (In reply to Jeroen Roovers from comment #7) > > > (In reply to Jeroen Roovers from comment #5) > > > > > > cmake also expects a local (bundled) copy of http-parser. > > > > Is there a problem with this? > > Well, it complicates the (e)build script and it pulls in more dependencies, > that's all. I.e. when libhttp_parser is already present on the system, no local (bundled) copy should be needed at all.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07151b2923151018c1ce068b0793fd120f3d8e4d commit 07151b2923151018c1ce068b0793fd120f3d8e4d Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2020-10-26 07:35:39 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2020-10-26 07:39:04 +0000 net-analyzer/tcpflow: Remove last-rited pkg Closes: https://bugs.gentoo.org/735392 Signed-off-by: Michał Górny <mgorny@gentoo.org> net-analyzer/tcpflow/Manifest | 3 -- .../files/tcpflow-1.5.0_alpha-libcapng.patch | 13 ----- .../tcpflow/files/tcpflow-1.5.2-gentoo.patch | 61 ---------------------- net-analyzer/tcpflow/metadata.xml | 11 ---- net-analyzer/tcpflow/tcpflow-1.5.2-r1.ebuild | 60 --------------------- profiles/package.mask | 1 - 6 files changed, 149 deletions(-)
wasn't the upstream maintainer actually helping to fix this problem? :/
(In reply to Adrian from comment #14) > wasn't the upstream maintainer actually helping to fix this problem? :/ Yeah, it looks like we could restore this actually with a bump.
Hi. I just posted tcpflow 1.6.1 on github.com. It removes the python2 dependency.
It's just a patch. I'm doing a complete rewrite of tcpflow and bulk_extractor, but I wanted to get out this fix for you.
*bump* any chance the python-less version can be restored?
Here is 1.6.1 ebuild, based on https://github.com/simsong/tcpflow/commit/a5965b11a332fe908ab1ed136b14803920e8ecdb : https://github.com/Perlovka/portage-overlay/tree/master/net-analyzer/tcpflow
(In reply to Michael Perlov from comment #19) > Here is 1.6.1 ebuild, based on > https://github.com/simsong/tcpflow/commit/ > a5965b11a332fe908ab1ed136b14803920e8ecdb : > > https://github.com/Perlovka/portage-overlay/tree/master/net-analyzer/tcpflow This ebuild works for me (tested with no use flags set). I also didn't catch any QC messages.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61e6ac60c4a99110f68f02dbc16556e1a493b3d3 commit 61e6ac60c4a99110f68f02dbc16556e1a493b3d3 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-02-12 15:38:57 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-02-12 15:39:02 +0000 net-analyzer/tcpflow: restore package with 1.6.1 (python 3) Closes: https://bugs.gentoo.org/735392 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Sam James <sam@gentoo.org> net-analyzer/tcpflow/Manifest | 3 + .../files/tcpflow-1.5.0_alpha-libcapng.patch | 13 +++++ .../tcpflow/files/tcpflow-1.5.2-gentoo.patch | 64 ++++++++++++++++++++++ net-analyzer/tcpflow/metadata.xml | 11 ++++ net-analyzer/tcpflow/tcpflow-1.6.1.ebuild | 63 +++++++++++++++++++++ 5 files changed, 154 insertions(+)
(In reply to Simson from comment #17) > It's just a patch. I'm doing a complete rewrite of tcpflow and > bulk_extractor, but I wanted to get out this fix for you. Thanks a bunch for doing this. The main guy working on this package retired but I've added it now.
