Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 73327 - baselayout: various fixes in /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-*
Summary: baselayout: various fixes in /lib/rcscripts/net.modules.d/helpers.d/{dhclient...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo's Team for Core System packages
Depends on:
Reported: 2004-12-04 04:43 UTC by Benoit Boissinot
Modified: 2004-12-04 08:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

correct the permissions of /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-* (fix-perms.patch,503 bytes, patch)
2004-12-04 04:44 UTC, Benoit Boissinot
Details | Diff
fixes typo in helpers.d/dhclient-ifconfig (dhclient-ifconfig.patch,434 bytes, patch)
2004-12-04 07:02 UTC, Benoit Boissinot
Details | Diff
fix a typo in helpers.d/udhcpc-ifconfig (udhcpc-ifconfig.patch,654 bytes, patch)
2004-12-04 07:04 UTC, Benoit Boissinot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benoit Boissinot 2004-12-04 04:43:20 UTC
The files in /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-* should have the executable bit set. Without this, the net scripts doesn't work with
dhclient. (permission denied).

Reproducible: Always
Steps to Reproduce:
1. emerge baselayout
2. /etc/init.d/net.eth0 restart

Actual Results:  
dhclient: execve (/lib/rcscripts/net.modules.d/helpers.d/dhclient-iproute2,
...): Permission denied

arakou tonfa # emerge info
Portage 2.0.51-r8 (default-linux/x86/2004.3, gcc-3.4.3, glibc-,
2.6.10-rc2-mm4-arakou i686)
System uname: 2.6.10-rc2-mm4-arakou i686 AMD Athlon(TM) XP 2500+
Gentoo Base System version 1.6.7
Python:              dev-lang/python-2.3.4 [2.3.4 (#1, Sep  8 2004, 15:27:57)]
dev-lang/python:     2.3.4
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.8.5-r2, 1.5, 1.4_p6, 1.6.3, 1.7.9, 1.9.3
sys-devel/libtool:   1.5.10
CFLAGS="-O3 -march=athlon-xp -pipe -fomit-frame-pointer -ffast-math -mfpmath=sse
-m3dnow -mmmx -msse"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d"
CXXFLAGS="-O3 -march=athlon-xp -pipe -fomit-frame-pointer -ffast-math
-mfpmath=sse -m3dnow -mmmx -msse"
FEATURES="autoaddcvs autoconfig buildsyspkg ccache distlocks gpg sandbox sfperms
strict userpriv usersandbox"
USE="3dnow X acpi alsa avi berkdb bitmap-fonts bonobo cdr crypt distcc dvd
encode f77 fam flac foomaticdb fortran gdbm gif gtk gtk2 imagemagick imlib ipv6
jpeg libg++ libwww mad mikmod mmx mpeg ncurses nls nptl oggvorbis opengl pam
pdflib perl png python quicktime radeon readline samba slang sse ssl svga tcpd
tetex tiff truetype unicode vi x86 xine xml xml2 xv zlib"
Comment 1 Benoit Boissinot 2004-12-04 04:44:08 UTC
Created attachment 45256 [details, diff]
correct the permissions of /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-*
Comment 2 Benoit Boissinot 2004-12-04 07:02:37 UTC
Created attachment 45266 [details, diff]
fixes typo in helpers.d/dhclient-ifconfig

fixe a trivial typo in dhclient-ifconfig
Comment 3 Benoit Boissinot 2004-12-04 07:04:22 UTC
Created attachment 45267 [details, diff]
fix a typo in helpers.d/udhcpc-ifconfig

I think there is a typo in udhcpc-ifconfig (eth1 -> ${interface})
Comment 4 Benoit Boissinot 2004-12-04 07:04:54 UTC
i added various fixes to helpers.d
Comment 5 Roy Marples (RETIRED) gentoo-dev 2004-12-04 07:55:56 UTC
I've applied the dhlcient and udhcpc fixes to CVS

I'll pester agriffis to modify the ebuild
Comment 6 Martin Schlemmer (RETIRED) gentoo-dev 2004-12-04 08:01:26 UTC
This seems like the better fix, no? (depending on if all helpers should
be executable ...)

Index: baselayout-1.11.7-r1.ebuild
RCS file: /var/cvsroot/gentoo-x86/sys-apps/baselayout/baselayout-1.11.7-r1.ebuild,v
retrieving revision 1.1
diff -u -r1.1 baselayout-1.11.7-r1.ebuild
--- baselayout-1.11.7-r1.ebuild 4 Dec 2004 07:14:14 -0000       1.1
+++ baselayout-1.11.7-r1.ebuild 4 Dec 2004 15:59:56 -0000
@@ -343,8 +343,8 @@
        # problematic with CONFIG_PROTECT
        insinto /lib/rcscripts/net.modules.d
        doins ${S}/lib/rcscripts/net.modules.d/*
-       insinto /lib/rcscripts/net.modules.d/helpers.d
-       doins ${S}/lib/rcscripts/net.modules.d/helpers.d/*
+       exeinto /lib/rcscripts/net.modules.d/helpers.d
+       doexe ${S}/lib/rcscripts/net.modules.d/helpers.d/*

        # Install baselayout documentation
Comment 7 Benoit Boissinot 2004-12-04 08:05:12 UTC
there is no need for 'config-system' and 'functions' to be made executable (they are sourced). I don't know if that matters.


Comment 8 Aron Griffis (RETIRED) gentoo-dev 2004-12-04 08:12:29 UTC
Fixed in baselayout-1.11.7-r2.  Thanks for the patches!
Comment 9 Aron Griffis (RETIRED) gentoo-dev 2004-12-04 08:14:33 UTC
Btw, I just changed the ebuild to use cp -a instead of doins.  The knowledge of the correct permissions is already in rc-scripts.  There is no need to duplicate that knowledge to the baselayout ebuild