Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733020 - perl-module.eclass: Add DIST_WIKI array for automatically giving links to wiki pages.
Summary: perl-module.eclass: Add DIST_WIKI array for automatically giving links to wik...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: perl-eclass
  Show dependency tree
 
Reported: 2020-07-17 06:13 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2021-06-22 00:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2020-07-17 06:13:01 UTC
I've been doing this manually a lot lately, and I think this can be safely generalised.

Firstly:

perl-functions.eclass should have a function such as perl_wiki that constructs a series of variables:

  ${DIST_WIKI} -> "https://wiki.gentoo.org/wiki/Project:Perl/maint-notes/${CATEGORY}/${PN}"
  ${DIST_WIKI_FEATURES} -> "${DIST_WIKI}#Optional_Features"
  ${DIST_WIKI_TESTS}  -> "${DIST_WIKI}#Testing"

And perl-module.eclass should have a bash array like:

  DIST_WIKI=( "features" "tests" )


When DIST_WIKI includes "features", pkg_postinst should automatically do:

  ewarn "This package may require additional dependencies/steps for some optional features."
  ewarn "For details, see:"
  ewarn " ${DIST_WIKI_FEATURES}"

When DIST_WIKI includes "tests", src_install should automatically do:

  ewarn "This package may require additional dependencies/steps for comprehensive testing"
  ewarn "For details, see:"
  ewarn " ${DIST_WIKI_TESTS}"


That way, if later we don't like how this is implemented in wiki, we can reorient it somewhat.

And if the wiki eventually gets a better namespace to link to this stuff, we can migrate it to the new URL easily.

The objective here is to make the wikification consistent.
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2020-07-17 06:14:47 UTC
I also think there may be a better, offline-accessible way to stash this content, but this is the best I've got so far.
Comment 2 Larry the Git Cow gentoo-dev 2021-06-19 19:12:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0dd937bace2f074eee910c733ca608627272b60d

commit 0dd937bace2f074eee910c733ca608627272b60d
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2021-06-18 21:39:33 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-06-19 19:10:33 +0000

    perl-module.eclass: Add EAPI=8 support
    
    New features: DIST_WIKI and DIST_MAKE
    File permissions are fixed on installation
    
    Bug: https://bugs.gentoo.org/733020
    Bug: https://bugs.gentoo.org/554346
    Bug: https://bugs.gentoo.org/261375
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 eclass/perl-module.eclass | 89 ++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 76 insertions(+), 13 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dcb3a8f170cae1fa08fc8ecb903b805d11ab6e9b

commit dcb3a8f170cae1fa08fc8ecb903b805d11ab6e9b
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2021-06-18 21:26:33 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-06-19 19:10:20 +0000

    perl-functions.eclass: Add new helpers for EAPI=8 ...
    
    ... and fix an existing one.
    
    fperms works on ${D} by default, so we can give it / to operate on.
    
    Bug: https://bugs.gentoo.org/554346
    Bug: https://bugs.gentoo.org/733020
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 eclass/perl-functions.eclass | 35 ++++++++++++++++++++++++++++++++---
 1 file changed, 32 insertions(+), 3 deletions(-)
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2021-06-22 00:27:04 UTC
Implemented with EAPI=8