Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 731258 - sys-firmware/nvidia-firmware-*: dependency on python 2.7 (via PYTHON_COMPAT)
Summary: sys-firmware/nvidia-firmware-*: dependency on python 2.7 (via PYTHON_COMPAT)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2020-10-19
Assignee: Christian Ruppert (idl0r)
URL: https://github.com/imirkin/re-vp2/pull/7
Whiteboard:
Keywords: PMASKED, PullRequest
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2020-07-07 10:27 UTC by satmd
Modified: 2020-09-19 18:01 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch of original ebuild to r1 (nvidia-firmware-3.40.32-r1.patch,1.06 KB, patch)
2020-07-07 11:09 UTC, satmd
Details | Diff
patch of original to 340.108 (nvidia-firmware-340.108.patch,1.36 KB, patch)
2020-08-19 18:41 UTC, Julien
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description satmd 2020-07-07 10:27:26 UTC
The nvidia-firmware package uses the script extract_firmware.py which depends on python 2.7.

Luckily, someone already looked at this from an upstream perspective, so maybe we can replace the script by an updated one.

Original Issue (Python2 dep): https://github.com/imirkin/re-vp2/issues/4
PR for an updated script: https://github.com/imirkin/re-vp2/pull/7
Current home of the updated script file: https://github.com/envytools/firmware


Reproducible: Always

Steps to Reproduce:
1. Mask python2.7
2. emerge -1 nvidia-firmware
3. cannot emerge due to dependencies
Actual Results:  
nvidia-firmware tries to pull in python 2.7

Expected Results:  
duh. nvidia-firmware does NOT try to pull in python 2.7, but something newer.

Suggestion for a solution are included in the description
Comment 1 satmd 2020-07-07 10:31:49 UTC
Blocks python3 tracker bug
Comment 2 satmd 2020-07-07 11:04:41 UTC
I've compared the original script, the preliminary one from the pull request and the current master blob.

Results:
1. broken
2. runs but fails at extracting 
3. works as intended, no error messages

Patch incoming
Comment 3 satmd 2020-07-07 11:09:40 UTC
Created attachment 648230 [details, diff]
Patch of original ebuild to r1

Please note: the patch keeps the filename nvidia_extract_firmware.py, I don't know wether that's a good idea.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-08-16 10:55:54 UTC
ping.
Comment 5 Julien 2020-08-19 18:41:00 UTC
Created attachment 655504 [details, diff]
patch of original to 340.108

I suggest to:
- keep original author and use https://github.com/envytools/firmware
(see https://github.com/imirkin/re-vp2/pull/7)
- use extractor version instead of nvidia version in filename
- update to nvidia 340.108 as it's the latest supported
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-01 10:04:18 UTC
ping.
Comment 7 Larry the Git Cow gentoo-dev 2020-09-19 18:01:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=103d75937a1ee825c84aec68f1caeacb66972d44

commit 103d75937a1ee825c84aec68f1caeacb66972d44
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-09-19 18:00:49 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-09-19 18:00:49 +0000

    sys-firmware/nvidia-firmware: Remove old
    
    Closes: https://bugs.gentoo.org/731258
    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/package.mask                              |  1 -
 sys-firmware/nvidia-firmware/Manifest              |  3 --
 .../nvidia-firmware/nvidia-firmware-325.15.ebuild  | 43 ----------------------
 .../nvidia-firmware/nvidia-firmware-340.32.ebuild  | 43 ----------------------
 4 files changed, 90 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=14955162c5e32b437bf3ad88a687466d64563a06

commit 14955162c5e32b437bf3ad88a687466d64563a06
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-09-19 18:00:46 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-09-19 18:00:46 +0000

    sys-firmware/nvidia-firmware: migrate to Python 3
    
    * Migrate to Python 3 and EAPI 7.
      Updated SRC_URI for python firmware extractor.
    
    Bug: https://bugs.gentoo.org/731258
    Closes: https://github.com/gentoo/gentoo/pull/17600
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 sys-firmware/nvidia-firmware/Manifest              |  1 +
 .../nvidia-firmware-340.32-r1.ebuild               | 44 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)