Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730766 - x11-libs/gtksourceview-4.6.1: /usr/share/gtksourceview-4/language-specs/gentoo.lang is broken
Summary: x11-libs/gtksourceview-4.6.1: /usr/share/gtksourceview-4/language-specs/gento...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-04 21:38 UTC by Dmitriy Baranov
Modified: 2023-10-12 12:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitriy Baranov 2020-07-04 21:38:35 UTC
The current version of x11-libs/gtksourceview/files/2.0/gentoo.lang is not applicable for 4.6.1.
Gedit does not highlight *.ebuild/*.eclass files content.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2020-08-31 07:00:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e990aec230b23ed3652c2c740c719fae1229622

commit 8e990aec230b23ed3652c2c740c719fae1229622
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2020-08-31 07:00:12 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2020-08-31 07:00:12 +0000

    x11-libs/gtksourceview: carry over stable for ebuild highlight fix
    
    Bug: https://bugs.gentoo.org/730766
    Package-Manager: Portage-2.3.103, Repoman-2.3.20
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 x11-libs/gtksourceview/gtksourceview-4.6.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06334c394e4dc5827778387e5086813af9527b39

commit 06334c394e4dc5827778387e5086813af9527b39
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2020-08-31 06:54:10 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2020-08-31 06:54:22 +0000

    x11-libs/gtksourceview: quick-fix gentoo syntax highlighting
    
    This makes it not error and restore some basic highlighting for
    ebuild and eclass files, though still does not update to all the
    other changes in gtksourceview - for example not all built-in
    commands might be updated, as the bare minimum was done, while
    a full recheck against upstream sh.lang is really needed.
    
    Bug: https://bugs.gentoo.org/730766
    Package-Manager: Portage-2.3.103, Repoman-2.3.20
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 x11-libs/gtksourceview/files/4.6-gentoo.lang       | 111 +++++++++++++++++++++
 .../gtksourceview/gtksourceview-4.6.1-r1.ebuild    |  68 +++++++++++++
 2 files changed, 179 insertions(+)
Comment 2 tt_1 2023-08-30 09:41:45 UTC
it's broken again with the recent gnome stable update :(
Comment 3 Mart Raudsepp gentoo-dev 2023-08-30 11:43:17 UTC
It would be nice to have a volunteer to clean this up and maybe even upstream it.
Comment 4 tt_1 2023-08-30 15:10:57 UTC
The old and working ebuild is gone, I can't even see what the problem actually is.
Comment 5 Matt Turner gentoo-dev 2023-08-30 16:28:31 UTC
(In reply to tt_1 from comment #4)
> The old and working ebuild is gone, I can't even see what the problem
> actually is.

Is anything here actually affected by the ebuild? I don't think it is, but in any case... do you know how to use git? Old ebuilds aren't permanently inaccessible once they're removed.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dee9527dd4dccdd806f41155e73827d4c39af5a7 looks like the only change to 4.6-gentoo.lang.

Can you try reverting that?
Comment 6 tt_1 2023-09-17 17:24:49 UTC
hi, reverting it doesn't bring back the old behavior in gedit for me.
Comment 7 tt_1 2023-10-12 12:21:44 UTC
The newly broken gentoo.lang file for gedit cannot be fixed via gtksourceview, because it now depends on gui-libs/libgedit-gtksourceview instead.