Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 730352 - dev-lua/luasec uses bundled files from dev-lua/luasocket
Summary: dev-lua/luasec uses bundled files from dev-lua/luasocket
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Azamat H. Hackimov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: bundled-libs
  Show dependency tree
 
Reported: 2020-07-01 12:34 UTC by Azamat H. Hackimov
Modified: 2021-10-19 19:56 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Azamat H. Hackimov 2020-07-01 12:34:27 UTC
luasec uses some files from luasocket directly. Makefile has options that can switch to external luasocket library (https://github.com/brunoos/luasec/blob/master/Makefile#L5).
Comment 1 Larry the Git Cow gentoo-dev 2020-07-09 07:54:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1bbe799e8f7ed31a8a6bc2c6651215bf9d06fac

commit f1bbe799e8f7ed31a8a6bc2c6651215bf9d06fac
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-07-07 09:23:57 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-09 07:54:28 +0000

    dev-lua/luasocket: install headers
    
    Install headers needed for other packages.
    Bug: https://bugs.gentoo.org/730352
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16527
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-lua/luasocket/luasocket-3.0_rc1-r5.ebuild | 58 +++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
Comment 2 Conrad Kostecki gentoo-dev 2020-10-11 23:15:36 UTC
@Azamat: What's the status here?
Comment 3 Azamat H. Hackimov 2020-10-13 15:42:00 UTC
Needs to adapts and push to luasocket upstream API publication https://github.com/diegonehab/luasocket/pull/80

Unfortunately, right now I don't have much time for this, I'll do it later.
Comment 4 Conrad Kostecki gentoo-dev 2021-03-06 20:41:04 UTC
(In reply to Azamat H. Hackimov from comment #3)
> Needs to adapts and push to luasocket upstream API publication
> https://github.com/diegonehab/luasocket/pull/80
> 
> Unfortunately, right now I don't have much time for this, I'll do it later.

Did you had any time? :-)
Comment 5 Larry the Git Cow gentoo-dev 2021-10-19 19:56:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d98f204040e019732c3a6b24b3f4095b34ff782

commit 3d98f204040e019732c3a6b24b3f4095b34ff782
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2021-10-18 22:35:24 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-10-19 19:55:45 +0000

    dev-lua/luasec: unbundle luasocket usage
    
    Closes: https://github.com/gentoo/gentoo/pull/22631
    Closes: https://bugs.gentoo.org/730352
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 dev-lua/luasec/luasec-1.0.2-r1.ebuild | 89 +++++++++++++++++++++++++++++++++++
 1 file changed, 89 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=634e9eb09ef7db117ac05ad24926a6078eb07170

commit 634e9eb09ef7db117ac05ad24926a6078eb07170
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2021-10-18 22:29:34 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-10-19 19:55:44 +0000

    dev-lua/luasocket: publish API and sonames
    
    Add patches to publish API and sonames for external linking (see #730352 for
    rationale).
    Patches available at https://github.com/winterheart/luasocket/tree/public-api
    
    Closes: https://github.com/gentoo/gentoo/pull/22631
    Bug: https://bugs.gentoo.org/730352
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../luasocket-3.0_rc1_p20200328_makefile.patch     |  89 +++++++
 .../luasocket-3.0_rc1_p20200328_publish_API.patch  | 294 +++++++++++++++++++++
 .../luasocket-3.0_rc1_p20200328-r103.ebuild        |  90 +++++++
 3 files changed, 473 insertions(+)