Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 729924 - dev-lang/ispc does not build with LLVM 10
Summary: dev-lang/ispc does not build with LLVM 10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christoph Junghans (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-27 16:28 UTC by Guillaume BRUN
Modified: 2020-06-28 16:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild (ispc-9999.ebuild,1.09 KB, text/plain)
2020-06-27 16:28 UTC, Guillaume BRUN
Details
Gentoo-specific patch (ispc-9999-cmake-gentoo-release.patch,507 bytes, patch)
2020-06-27 16:29 UTC, Guillaume BRUN
Details | Diff
Remove -Werror from CFLAGS (ispc-9999-werror.patch,737 bytes, patch)
2020-06-27 16:29 UTC, Guillaume BRUN
Details | Diff
LLVM10 compatibility (ispc-9999-llvm-10.patch,4.56 KB, patch)
2020-06-27 16:30 UTC, Guillaume BRUN
Details | Diff
Ebuild for 1.13.0 (ispc-1.13.0.ebuild,1.09 KB, text/plain)
2020-06-27 17:38 UTC, Guillaume BRUN
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume BRUN 2020-06-27 16:28:41 UTC
Created attachment 646852 [details]
Ebuild

ispc (no matter the version) doesn't build against LLVM10.

Moreover, current (-9999) ispc uses cmake, and doesn't seem compatible with CMAKE_BUILD_TYPE=Gentoo.

This ebuild and set of patches address these issues.

One of the patches removes -Werror from build options, much like the original ebuild did (using sed on the Makefile), by patching CMakeLists.

The second fixes CMAKE_BUILD_TYPE=Gentoo.

The third addresses LLVM10 compatibility, and needs further runtime testing.
Comment 1 Guillaume BRUN 2020-06-27 16:29:15 UTC
Created attachment 646854 [details, diff]
Gentoo-specific patch
Comment 2 Guillaume BRUN 2020-06-27 16:29:44 UTC
Created attachment 646856 [details, diff]
Remove -Werror from CFLAGS
Comment 3 Guillaume BRUN 2020-06-27 16:30:05 UTC
Created attachment 646858 [details, diff]
LLVM10 compatibility
Comment 4 Guillaume BRUN 2020-06-27 17:38:40 UTC
Created attachment 646864 [details]
Ebuild for 1.13.0
Comment 5 Guillaume BRUN 2020-06-27 17:40:14 UTC
This new ebuild/patchset probably fixes 656632.

Also, they work on latest upstream release 1.13.0, making them a candidate for a version bump (although a proper src_test() implementation would be appreciated).

I posted the 1.13.0 ebuild for posterity - but it's the same as the -9999 one.
Comment 6 Larry the Git Cow gentoo-dev 2020-06-28 16:45:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f073ca910b7838d71043c2ae752fcd0d147937bd

commit f073ca910b7838d71043c2ae752fcd0d147937bd
Author:     Guillaume BRUN <the.cheaterman@gmail.com>
AuthorDate: 2020-06-28 15:48:55 +0000
Commit:     Christoph Junghans <junghans@gentoo.org>
CommitDate: 2020-06-28 16:43:42 +0000

    dev-lang/ispc: Add -1.13.0 ebuild
    
    Closes: https://bugs.gentoo.org/656632
    Closes: https://bugs.gentoo.org/729924
    Signed-off-by: Guillaume BRUN <the.cheaterman@gmail.com>
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Christoph Junghans <junghans@gentoo.org>

 dev-lang/ispc/Manifest                             |   1 +
 .../files/ispc-1.13.0-cmake-gentoo-release.patch   |  13 +++
 dev-lang/ispc/files/ispc-1.13.0-llvm-10.patch      | 106 +++++++++++++++++++++
 dev-lang/ispc/files/ispc-1.13.0-werror.patch       |  13 +++
 .../ispc/{ispc-9999.ebuild => ispc-1.13.0.ebuild}  |  27 ++++--
 5 files changed, 150 insertions(+), 10 deletions(-)