After updating to rsync-3.2.0: Jun 20 11:31:04 ragnarok kernel: process '/usr/bin/rsync' started with executable stack This also happens with vanilla upstream git (not sure why), I just noticed it too late for release. Probably just need to add noexecstack to LDFLAGS. Reproducible: Always Steps to Reproduce: 1. emerge rsync-3.2.0 2. rsync something 3. should find warning message in syslog (only once). Expected Results: Silence is golden.
A few more observations: - adding -z,noexecstack to LDFLAGS indeed fixes it - echo 1 > /sys/kernel/debug/clear_warn_once clears WARN_ONCE things so that one can test reproducibly without rebooting :)
It's due to raw assembly in lib/md5-asm-x86_64.s. I added --noexecstack to the build and have opened an upstream PR.
Created attachment 645432 [details, diff] Add --noexecstack for assembly routines This is now fixed upstream but of course no longer applies since the author decided to pile on a bunch of unrelated fixes on top. This patch works against 3.2.0.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6e2a72e6b9381c465f0e95914d044ba373f656ae commit 6e2a72e6b9381c465f0e95914d044ba373f656ae Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2020-06-21 09:30:29 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2020-06-21 09:31:07 +0000 net-misc/rsync: Revbump fixing stunnel build and removed execstack Closes: https://bugs.gentoo.org/728882 Closes: https://bugs.gentoo.org/728898 Package-Manager: Portage-2.3.101, Repoman-2.3.22 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> net-misc/rsync/files/rsync-3.2.0-noexecstack.patch | 24 +++++++++++ net-misc/rsync/files/rsync-3.2.0-simd_check.patch | 11 ----- .../{rsync-3.2.0.ebuild => rsync-3.2.0-r1.ebuild} | 48 ++++++++++++++-------- 3 files changed, 56 insertions(+), 27 deletions(-)
*** Bug 729146 has been marked as a duplicate of this bug. ***
