Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728808 - net-libs/nativebiginteger-0.9.{42,45}: missing patch
Summary: net-libs/nativebiginteger-0.9.{42,45}: missing patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: tharvik
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-19 18:52 UTC by Michael Mair-Keimberger (iamnr3)
Modified: 2020-09-13 00:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mair-Keimberger (iamnr3) 2020-06-19 18:52:47 UTC
Hi,

so this is a bit of a strange one.
I saw that both ebuilds do have pachtes applied via the PATCHES variable:
${FILESDIR}/${P}-asmfix.patch

However, this should actually refer to:
files/nativebiginteger-0.9.42-asmfix.patch
files/nativebiginteger-0.9.45-asmfix.patch

But both files doesn't exist in the files directory! Only nativebiginteger-0.9.36-asmfix.patch exists right now, which isn't used by the ebuilds.
So either please provide the patches or remove it from the ebuilds.

The strange part here is why the installation doesn't fail. Turns out that emerge doesn't even try to patch. This seems to be happen with ebuilds who call the java-pkg-2 eclass without defining src_prepare.
A quick look turned out that i found 2 other ebuilds who have patches defined via the PATCHES variable but they don't get applied. 
-> I will create another bug for that.

The easiest solution here is to simply add following to the ebuild. This seems to be added by others as well in order to apply the patches, however i'm not sure if that is sufficient here (in case patches are even needed...):

src_prepare(){
default
}
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-06-19 18:58:43 UTC
Nice spot! I think this is indeed needed with the Java eclasses.
Comment 2 Larry the Git Cow gentoo-dev 2020-09-13 00:44:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=458bf42448b5f431a1a9a14b4b3fa3b2ee35d445

commit 458bf42448b5f431a1a9a14b4b3fa3b2ee35d445
Author:     tharvik <tharvik@users.noreply.github.com>
AuthorDate: 2020-08-31 23:08:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-09-13 00:43:57 +0000

    net-libs/nativebiginteger: drop old patch
    
    Closes: https://bugs.gentoo.org/728808
    Package-Manager: Portage-3.0.4, Repoman-2.3.23
    Signed-off-by: Valérian Rousset <tharvik@users.noreply.github.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/nativebiginteger-0.9.36-asmfix.patch     | 31 ----------------------
 1 file changed, 31 deletions(-)