Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 725976 - sys-power/athcool fails to compile with -fno-common or gcc-10
Summary: sys-power/athcool fails to compile with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-05-29 06:49 UTC by Agostino Sarubbo
Modified: 2020-12-28 14:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,9.85 KB, text/plain)
2020-05-29 06:49 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-05-29 06:49:42 UTC
This is an auto-filed bug because sys-power/athcool fails to compile with -fno-common or gcc-10.
The issue was originally discovered on amd64, but it may be reproducible on other arches as well.
If you think that a different summary clarifies the issue better, feel free to change it.
Attached build log and emerge --info.

NOTE:
To reproduce this issue you may want to set CFLAGS="${CFLAGS} -fno-common" or compile it with gcc-10 that enables -fno-common by default.
Comment 1 Agostino Sarubbo gentoo-dev 2020-05-29 06:49:50 UTC
Created attachment 642402 [details]
build.log

build log and emerge --info
Comment 2 Anthony Parsons 2020-05-29 09:36:29 UTC
Maybe it's time to put this one out to pasture? The upstream URL's dead and iirc the only thing athcool actually did was to call HLT in a loop to enter C2, which newer kernels (basically anything after 2.4) do automatically.
Comment 3 Mike Gilbert gentoo-dev 2020-05-29 15:47:20 UTC
(In reply to Anthony Parsons from comment #2)

Reading the code, it appears to do more than that. The docs say it flips some bit(s) in a register in the motherboard chipset.

Anyway, this certainly seems like something that should be handled in the kernel, not userspace.
Comment 4 Larry the Git Cow gentoo-dev 2020-12-28 14:48:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f4aea9d7d862dc542123802e50c1a4781a7c5c3

commit 3f4aea9d7d862dc542123802e50c1a4781a7c5c3
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-12-28 14:48:00 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-12-28 14:48:00 +0000

    sys-power/athcool: Port to EAPI 7
    
    Closes: https://bugs.gentoo.org/725976
    Package-Manager: Portage-3.0.9, Repoman-3.0.1
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 sys-power/athcool/athcool-0.3.12.ebuild                     | 11 ++++++-----
 ...thcool-0.3.11-build.patch => athcool-0.3.12-build.patch} |  0
 sys-power/athcool/files/athcool-0.3.12-fno-common.patch     | 13 +++++++++++++
 3 files changed, 19 insertions(+), 5 deletions(-)