Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 719440 - media-video/obs-studio-25.0.3: Incorrectly uses github tar releases
Summary: media-video/obs-studio-25.0.3: Incorrectly uses github tar releases
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chiitoo
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-25 19:06 UTC by kkartaltepe
Modified: 2020-05-05 06:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kkartaltepe 2020-04-25 19:06:58 UTC
Github autogenerated tar releases cannot be disabled upstream and do not include submodules. The upstream recommendation[1] is to always use git with submodules in order to have a complete build.

Without submodules features such as mixer FTL support are missing. In the future if browser source is desired it is also a submodule.

1: https://github.com/obsproject/obs-studio/wiki/Install-Instructions#linux-build-directions
Comment 1 Andreas Sturmlechner gentoo-dev 2020-04-25 19:17:18 UTC
Upstream recommendations are one thing.

GitHub submodules however most of the time imply bundled dependencies, and we despise bundled dependencies and only use them if not at all otherwise possible.
Comment 2 kkartaltepe 2020-04-25 19:58:48 UTC
Packagers are of course free to de-vendor whatever they want. Though im not sure if the mixer SDK even supports this. Nor will obs-browser.

But its important that packagers do not mistake the github tar ball as the intended release.
Comment 3 Andreas Sturmlechner gentoo-dev 2020-04-26 14:30:59 UTC
Yes, if available, and unfortunately that is less and less the case with GitHub based upstreams, the proper release tarball should be used.
Comment 4 Andreas Sturmlechner gentoo-dev 2020-05-03 18:55:34 UTC
(In reply to kkartaltepe from comment #0)
> The upstream recommendation[1] is to always use git with
> submodules in order to have a complete build.
Well, that is not an option for distribution packaging. It is unfortunate that upstream is too lazy to create proper release tarballs themselves.

One way *could* be to workaround that by adding submodule tarballs separately to SRC_URI for those that are relevant.
Comment 5 Chiitoo gentoo-dev 2020-05-05 06:07:57 UTC
I've definitely kept them submodules in mind, to have them handled as needed, but so far I've not seen any related to Linux use.  That said, I had not bumped into FTL before (in the OBS Studio sense), and no one had requested support for it to be added.

As mentioned, for actual release packaging, using git tags isn't really feasible, unless we were to do snapshots only, but I don't see the point in that since the sources are available as plain downloads as well (even if incomplete in a sense).

I will look into packaging FTL soon (and the browser source, once it's ready), probably via the GitHub releases of its repository unless there is a very good reason to not do that.
Comment 6 kkartaltepe 2020-05-05 06:17:52 UTC
> unless there is a very good reason to not do that.

If i remember correctly it was submoduled because the sdk was happy to break source compatibility more or less every version. But it hasnt been touched for two years since Microsoft acquired them. So this might not be too much of a worry on packagers.