Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bugzilla DB migration completed. Please report issues to Infra team via email via infra@gentoo.org or IRC
Bug 718618 - media-sound/picard: Should have an optional dependency on dev-python/python-discid
Summary: media-sound/picard: Should have an optional dependency on dev-python/python-d...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-20 12:47 UTC by Erik Zeek
Modified: 2020-08-23 15:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Zeek 2020-04-20 12:47:59 UTC
As mentioned in the INSTALL.md file[1], python-discid or python-libdiscid are, "Required for CD lookups." Python-discid is currently available.

Picard functions without the dependency (except for the CD lookup feature), so the dependency should probably be optional.


[1] https://github.com/metabrainz/picard/blob/master/INSTALL.md
Comment 1 Larry the Git Cow gentoo-dev 2020-08-23 15:50:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b40bade6810a547235a1e5312d03244d741f236

commit 3b40bade6810a547235a1e5312d03244d741f236
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-08-23 15:48:44 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-08-23 15:48:44 +0000

    media-sound/picard: added discid use flag
    
    based on patch by Florian Schmaus <flo@geekplace.eu>
    
    Closes: https://bugs.gentoo.org/718618
    Closes: https://github.com/gentoo/gentoo/pull/15945
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/picard/metadata.xml        | 3 +++
 media-sound/picard/picard-2.3.1.ebuild | 6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)