Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716554 - games-fps/sauerbraten-9999 live ebuild
Summary: games-fps/sauerbraten-9999 live ebuild
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2020-04-07 09:42 UTC by brankob
Modified: 2021-04-22 14:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (sauerbraten-9999-r4.ebuild,3.42 KB, text/plain)
2020-04-07 09:43 UTC, brankob
Details
new version ( without games eclass) (sauerbraten-9999-r4.ebuild,3.12 KB, text/plain)
2021-03-26 07:39 UTC, brankob
Details

Note You need to log in before you can comment on or make changes to this bug.
Description brankob 2020-04-07 09:42:47 UTC
currrent packaged versions are old and doen'w work with wayland.

So I tweaked the last ebuild to source from the svn repo, which has been updated to use SDL2, whch works with wayland natively.

It works for me on sway/wayland just fine.

Attached the ebuild.

Reproducible: Always
Comment 1 brankob 2020-04-07 09:43:19 UTC
Created attachment 631082 [details]
new ebuild
Comment 2 Jonas Stein gentoo-dev 2020-04-07 15:17:13 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* can't you use a specific commit instead a 9999? It will less often break.
* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck
* We always try to use the latest EAPI, please bump to EAPI=7
* Please remove obsolete lines
* remove KEYWORDS for 9999
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
* A bot can look for additional mistakes, if you upload a PR via github
* We can help you on IRC #gentoo-dev-help to improve the ebuild, if you got stuck.
Comment 3 brankob 2020-04-10 09:56:04 UTC
I know about that version. That too is old.
I've used it until recently.

But htat version still doessn't work with Wayland - it still uses SDL1.

Meanwhile, current latest svn stuff works great with wayland.

I've corrreected the ebuild (  thrown outr games eclass stuff, but have a few snags left. Will upload it shortly...
Comment 4 jospezial 2021-03-23 17:31:11 UTC
(In reply to Branko Badrljica from comment #3)
> I know about that version. That too is old.
> I've used it until recently.
> 
> But htat version still doessn't work with Wayland - it still uses SDL1.
> 
> Meanwhile, current latest svn stuff works great with wayland.
> 
> I've corrreected the ebuild (  thrown outr games eclass stuff, but have a
> few snags left. Will upload it shortly...

https://github.com/gentoo/gentoo/pull/19820
Remove games.eclass
Comment 5 brankob 2021-03-26 07:39:01 UTC
Created attachment 693813 [details]
new version ( without games eclass)

prablably couple other changes done , too.

This is latest version that I'm using.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-10 11:14:47 UTC
If it's still relevant, I'd appreciate you posting the patch in git format-patch format or as a GitHub PR. Either way, can you include the GCO sign off in a comment?
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-22 14:55:20 UTC
(In reply to Sam James from comment #6)
> If it's still relevant, I'd appreciate you posting the patch in git
> format-patch format or as a GitHub PR. Either way, can you include the GCO
> sign off in a comment?

I posted this because I worked on this package when fixing all the games.eclass consumers, but I appreciate it’s been a while. I’ve bumped for bug 759535.

Please reopen if you are still bothered about a live ebuild. Not sure if we really need one.