Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716446 - x11-terms/terminator-1.92 version bump with python3 support
Summary: x11-terms/terminator-1.92 version bump with python3 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL: https://bugs.launchpad.net/terminator...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2020-04-06 11:20 UTC by Alexey
Modified: 2020-06-05 09:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2020-04-06 11:20:59 UTC
I wrote https://github.com/gentoo/gentoo/pull/14826 a while ago, and it's still not reviewed.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-04-11 09:07:30 UTC
After reading through $URL I found there's now a fork at GitHub:

https://github.com/gnome-terminator/terminator

Maybe it makes more sense to do a snapshot from there if they do not make a release in time, rather than carrying a >200kb patchset.
Comment 2 Alexey 2020-04-11 09:41:56 UTC
Definitely! Updated the PR.
Comment 3 Alexey 2020-04-18 12:31:53 UTC
I've updated the PR from a snapshot to a newly released 1.92
Comment 4 Larry the Git Cow gentoo-dev 2020-04-30 23:18:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53f47bd928f3b470b69a3bfbf44d318dec4e1a6a

commit 53f47bd928f3b470b69a3bfbf44d318dec4e1a6a
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-03-03 01:08:52 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2020-04-30 23:18:40 +0000

    x11-terms/terminator: bump version, support py3
    
    Some notes:
    
    * I replaced gnome2 with xdg because gnome2 doesn't work with EAPI 7. I
      don't know whether the rest of things gnome2 eclass did is important.
    * I put myself to maintainer because Andreas Sturmlechner told me to.
    
    It seems to work, and the test passes.
    
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Alexey Sokolov <sokolov@google.com>
    Closes: https://bugs.gentoo.org/716446
    Closes: https://github.com/gentoo/gentoo/pull/14826
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 x11-terms/terminator/Manifest                      |  1 +
 .../files/terminator-1.91-without-icon-cache.patch | 16 ++++++
 x11-terms/terminator/metadata.xml                  | 10 ++--
 x11-terms/terminator/terminator-1.92.ebuild        | 58 ++++++++++++++++++++++
 4 files changed, 82 insertions(+), 3 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2020-06-05 09:43:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa86a9e1dfcf443daaef7ae276e15318d6dfa8d7

commit fa86a9e1dfcf443daaef7ae276e15318d6dfa8d7
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-06-05 09:33:46 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-06-05 09:43:20 +0000

    x11-terms/terminator: Drop 1.91
    
    Bug: https://bugs.gentoo.org/716446
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 x11-terms/terminator/Manifest                      |  1 -
 .../terminator/files/0.90-without-icon-cache.patch | 11 ----
 x11-terms/terminator/terminator-1.91.ebuild        | 67 ----------------------
 3 files changed, 79 deletions(-)