Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711866 - media-gfx/iscan-3.62 version bump
Summary: media-gfx/iscan-3.62 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Schultz
URL: https://slonko.net/git/portage/tree/m...
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-08 13:48 UTC by Marcin Deranek
Modified: 2020-04-13 07:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild (iscan-3.62.0.ebuild,1.67 KB, text/plain)
2020-03-08 13:48 UTC, Marcin Deranek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Deranek 2020-03-08 13:48:22 UTC
Please find a proposed ebuild for iscan version bump (3.62). A few modifications took place compared to version 3.61:
* gtkmm got slotted (apparently it only works with gtkmm-2.4)
* I had to ignore deprecation warnings otherwise it would not build (when gui use flag is used)
* as-needed flag had to be ignored otherwise we will end up with unresolved symbols
iscan (including gui) was successfully tested with Epson XP-8600 and iscan-plugin-network-nt (#711864)

Reproducible: Always
Comment 1 Marcin Deranek 2020-03-08 13:48:50 UTC
Created attachment 617488 [details]
Proposed ebuild
Comment 2 Jonas Stein gentoo-dev 2020-03-08 21:07:56 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman
* A bot can look for additional mistakes, if you upload a PR via github

* missing || die for
	rm -r upstream/boost
	sed -e 's|-Werror||g' -i configure.ac
Comment 3 Marcin Deranek 2020-03-09 17:58:27 UTC
Created https://github.com/gentoo/gentoo/pull/14907
Comment 4 Marcin Deranek 2020-04-10 17:29:02 UTC
Anything else I can do to help?
Comment 5 Larry the Git Cow gentoo-dev 2020-04-13 07:42:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa1150d2cd23ec945e0d71c105d132b98ea3524a

commit fa1150d2cd23ec945e0d71c105d132b98ea3524a
Author:     Marcin Deranek <marcin.deranek@slonko.net>
AuthorDate: 2020-03-09 17:54:37 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-04-13 07:41:29 +0000

    media-gfx/iscan: version bump to 3.62.0
    
    Closes: https://bugs.gentoo.org/711866
    Bug: https://bugs.gentoo.org/713554
    Signed-off-by: Marcin Deranek <marcin.deranek@slonko.net>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-gfx/iscan/Manifest            |  1 +
 media-gfx/iscan/iscan-3.62.0.ebuild | 85 +++++++++++++++++++++++++++++++++++++
 2 files changed, 86 insertions(+)