Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708302 - p.g.o: use RFC3339 date
Summary: p.g.o: use RFC3339 date
Status: RESOLVED FIXED
Alias: None
Product: Websites
Classification: Unclassified
Component: Packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Packages Website
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-04 23:29 UTC by Jonas Stein
Modified: 2023-02-18 16:35 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2020-02-04 23:29:56 UTC
https://packages.gentoo.org/ should use ISO date as in 
 YYYY-MM-DD
https://en.wikipedia.org/wiki/ISO_8601

instead of
 Tue, 4 Feb 2020 23:01 

I suggest to use UTC as timezone.
Do we need hours and minutes?

Perhaps it makes sense to use
<black>YYYY-MM-DD</black><grey>T</grey><black>hh:mm</black><grey>Z</grey>

Reproducible: Always
Comment 1 Alec Warner (RETIRED) archtester gentoo-dev Security 2020-05-26 07:53:10 UTC
I don't see any particular problem with the current format.

-A
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-05-26 15:25:34 UTC
Following standards is a good thing.
Comment 3 Jonas Stein gentoo-dev 2021-02-14 18:34:21 UTC
p.g.o looks great now.

The date format is now
2021-02-14 18:06:38 +0000 UTC 

I suggest to change it to
<black>YYYY-MM-DD</black><grey>T</grey><black>hh:mm</black><grey>Z</grey>
or 
<black>YYYY-MM-DD</black><grey>T</grey><black>hh:mm</black><grey>UTC</grey>

+0000 makes no sense, if this is constant for all entries.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-18 05:23:07 UTC
For the record, ISO 8601 is a horrible, closed standard.  Let's use RFC 3339 instead.

https://www.rfc-editor.org/rfc/rfc3339
Comment 5 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2023-02-18 13:03:41 UTC
I've updated the code to use RFC 3339 dates, for now deployed to staging pgo at https://packagestest.gentoo.org/

I hope that I fixed the format at all the places, but if someone finds a place I missed feel free to ping me and I'll fix it.

If the current staging deployment works fine for some more time, I will move it to production (main p.g.o site).
Comment 6 Larry the Git Cow gentoo-dev 2023-02-18 16:35:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/sites/soko.git/commit/?id=ccdb7db55740d2a83553dd9a6b2a19d455a5425f

commit ccdb7db55740d2a83553dd9a6b2a19d455a5425f
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2023-02-18 12:19:38 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2023-02-18 12:47:03 +0000

    Use RFC 3339 dates
    
    Closes: https://bugs.gentoo.org/708302
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 web/templates/about/status.tmpl                    |  2 +-
 web/templates/arches/changedVersionRows.tmpl       |  2 +-
 web/templates/layout/footer.tmpl                   |  2 +-
 web/templates/maintainer/components/changelog.tmpl | 16 ++++++++--------
 web/templates/packages/changedVersionRow.tmpl      |  2 +-
 web/templates/packages/changelog/changelog.tmpl    | 14 +++++++-------
 web/templates/packages/components/changelog.tmpl   | 16 ++++++++--------
 7 files changed, 27 insertions(+), 27 deletions(-)