Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706870 - sys-apps/ipmitool-1.8.18-r1 : fails to build with -fno-common or gcc-10
Summary: sys-apps/ipmitool-1.8.18-r1 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sysadmin Bugs
URL: https://github.com/ipmitool/ipmitool/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-28 18:27 UTC by Toralf Förster
Modified: 2020-08-19 22:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.84 KB, text/plain)
2020-01-28 18:27 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,115.10 KB, text/plain)
2020-01-28 18:27 UTC, Toralf Förster
Details
environment (environment,89.22 KB, text/plain)
2020-01-28 18:27 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,12.69 KB, application/x-bzip)
2020-01-28 18:27 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,13.60 KB, application/x-bzip)
2020-01-28 18:27 UTC, Toralf Förster
Details
sys-apps:ipmitool-1.8.18-r1:20200128-051950.log (sys-apps:ipmitool-1.8.18-r1:20200128-051950.log,106.12 KB, text/plain)
2020-01-28 18:28 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,37.09 KB, application/x-bzip)
2020-01-28 18:28 UTC, Toralf Förster
Details
files/ipmitool-1.8.18-fno-common.patch (ipmitool-1.8.18-fno-common.patch,661 bytes, patch)
2020-04-15 06:30 UTC, Jeroen Roovers (RETIRED)
Details | Diff
impitool-1.8.17-r1 build log (ipmitool-1.8.17-r1.build.log,176.88 KB, text/plain)
2020-07-15 21:32 UTC, Guy
Details
files/ipmitool-1.8.18-fno-common.patch (ipmitool-1.8.18-fno-common.patch,595 bytes, patch)
2020-07-16 10:04 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-28 18:27:42 UTC
ipmishell.c:228:39: warning: unused parameter ‘intf’ [-Wunused-parameter]
  228 | int ipmi_echo_main(struct ipmi_intf * intf, int argc, char ** argv)
      |                    ~~~~~~~~~~~~~~~~~~~^~~~
/bin/sh ../libtool --silent  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc  -O2 -pipe -march=native -fno-common -Wall -Wextra -std=gnu99 -pedantic -Wformat -Wformat-nonliteral -I /usr/include  -Wl,-O1 -Wl,--as-needed -o ipmitool ipmitool.o ipmishell.o ../lib/libipmitool.la plugins/libintf.la -lreadline -lncurses -ltinfo -lreadline -lncurses -ltinfo  -lcrypto
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ../lib/.libs/libipmitool.a(ipmi_hpmfwupg.o):(.bss+0x0): multiple definition of `gVersionInfo'; ipmitool.o:(.bss+0x20): first defined here
collect2: error: ld returned 1 exit status

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome_systemd-libressl-20200125-150902

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7 (uninstalled)
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.40.0 *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Tue, 28 Jan 2020 03:26:40 +0000

emerge -qpvO sys-apps/ipmitool
[ebuild  N    ] sys-apps/ipmitool-1.8.18-r1  USE="libressl -openipmi -static"
Comment 1 Toralf Förster gentoo-dev 2020-01-28 18:27:45 UTC
Created attachment 606244 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-28 18:27:49 UTC
Created attachment 606246 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-28 18:27:52 UTC
Created attachment 606248 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-28 18:27:55 UTC
Created attachment 606250 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-28 18:27:58 UTC
Created attachment 606252 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-01-28 18:28:03 UTC
Created attachment 606254 [details]
sys-apps:ipmitool-1.8.18-r1:20200128-051950.log
Comment 7 Toralf Förster gentoo-dev 2020-01-28 18:28:06 UTC
Created attachment 606256 [details]
temp.tbz2
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2020-04-15 06:30:14 UTC
Created attachment 632992 [details, diff]
files/ipmitool-1.8.18-fno-common.patch
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-04-15 06:34:11 UTC
Also note that:
1) Debian is at patchlevel 8 now.
2) the project appears to have moved to https://github.com/ipmitool/ipmitool - the old HOMEPAGE http://ipmitool.sf.net/ redirects to the SF project page, which has a note about the Github migration.
Comment 10 Guy 2020-07-15 21:32:48 UTC
Created attachment 649374 [details]
impitool-1.8.17-r1 build log

sys-apps/ipmitool-1.8.17-r1 no longer makes for (apparently) the same reasons.

Perhaps the package should be masked completely until 1.8.19 is released. The download page on the github sources has the following verbiage (https://github.com/ipmitool/ipmitool/releases/tag/IPMITOOL_1_8_18) 

"... released this on Jun 25, 2019 · 204 commits to master since this release.
This is Release 1.8.18 freshly rebuilt from github sources."

The source 1.8.18 files (from Oct 2016) I have (in /var/cache/distfiles) and that the ebuilds expect are the from the sf.net project page.
Comment 11 Guy 2020-07-15 21:34:23 UTC
I forgot to note I'm also on GCC10
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-16 09:49:28 UTC
Comment on attachment 649374 [details]
impitool-1.8.17-r1 build log

lanplus_crypt_impl.c: In function ‘lanplus_encrypt_aes_cbc_128’:
lanplus_crypt_impl.c:158:17: error: storage size of ‘ctx’ isn’t known
  158 |  EVP_CIPHER_CTX ctx;
      |                 ^~~
lanplus_crypt_impl.c:158:17: warning: unused variable ‘ctx’ [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-variable^G-Wunused-variable8;;^G]
lanplus_crypt_impl.c: In function ‘lanplus_decrypt_aes_cbc_128’:
lanplus_crypt_impl.c:233:17: error: storage size of ‘ctx’ isn’t known
  233 |  EVP_CIPHER_CTX ctx;
      |                 ^~~



That's bug #592494.
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-16 10:04:39 UTC
Created attachment 649446 [details, diff]
files/ipmitool-1.8.18-fno-common.patch

Actually, since gVersionInfo is only used in lib/ipmi_hpmfwupg.c, just declare it static there, and remove it from the (internal) header file include/ipmitool/ipmi_hpmfwupg.h.
Comment 14 Larry the Git Cow gentoo-dev 2020-08-19 21:28:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27c39af013c9ba5db43cd7f37eabb69b7d076873

commit 27c39af013c9ba5db43cd7f37eabb69b7d076873
Author:     Patrick McLean <patrick.mclean@sony.com>
AuthorDate: 2020-08-19 21:28:19 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2020-08-19 21:28:35 +0000

    sys-apps/ipmitool-1.8.18-r1: Fix build with gcc-10 (bug #706870)
    
    Closes: https://bugs.gentoo.org/706870
    Copyright: Sony Interactive Entertainment Inc.
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 .../files/ipmitool-1.8.18-fno-common.patch         | 22 ++++++++++++++++++++++
 sys-apps/ipmitool/ipmitool-1.8.18-r1.ebuild        |  1 +
 2 files changed, 23 insertions(+)
Comment 15 Jeroen Roovers (RETIRED) gentoo-dev 2020-08-19 22:10:04 UTC
(In reply to Larry the Git Cow from comment #14)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=27c39af013c9ba5db43cd7f37eabb69b7d076873
> 
> commit 27c39af013c9ba5db43cd7f37eabb69b7d076873
> Author:     Patrick McLean <patrick.mclean@sony.com>
> AuthorDate: 2020-08-19 21:28:19 +0000
> Commit:     Patrick McLean <chutzpah@gentoo.org>
> CommitDate: 2020-08-19 21:28:35 +0000
> 
>     sys-apps/ipmitool-1.8.18-r1: Fix build with gcc-10 (bug #706870)
>     
>     Closes: https://bugs.gentoo.org/706870
>     Copyright: Sony Interactive Entertainment Inc.
>     Package-Manager: Portage-3.0.4, Repoman-3.0.1
>     Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
> 
>  .../files/ipmitool-1.8.18-fno-common.patch         | 22
> ++++++++++++++++++++++
>  sys-apps/ipmitool/ipmitool-1.8.18-r1.ebuild        |  1 +
>  2 files changed, 23 insertions(+)

You are seriously claiming both copyright and authorship of the patch attached above for Sony? *slow clap*