Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706692 - media-sound/wavegain-1.3.1 : fails to build with -fno-common or gcc-10
Summary: media-sound/wavegain-1.3.1 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-27 17:33 UTC by Toralf Förster
Modified: 2020-08-08 16:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.53 KB, text/plain)
2020-01-27 17:33 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,145.01 KB, text/plain)
2020-01-27 17:33 UTC, Toralf Förster
Details
environment (environment,49.57 KB, text/plain)
2020-01-27 17:33 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,15.08 KB, application/x-bzip)
2020-01-27 17:33 UTC, Toralf Förster
Details
media-sound:wavegain-1.3.1:20200127-073350.log (media-sound:wavegain-1.3.1:20200127-073350.log,5.32 KB, text/plain)
2020-01-27 17:33 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,14.09 KB, application/x-bzip)
2020-01-27 17:33 UTC, Toralf Förster
Details
fix-for-fno-common.patch (fix-for-fno-common.patch,516 bytes, patch)
2020-05-16 02:26 UTC, Matt Whitlock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-27 17:33:36 UTC
wavegain.c: In function ‘write_gains’:
wavegain.c:524:36: warning: implicit declaration of function ‘getpid’ [-Wimplicit-function-declaration]
  524 |                 srand(time(NULL) ^ getpid());
      |                                    ^~~~~~
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/media-sound/wavegain-1.3.1/temp/ccrXvgUj.o:(.bss+0x204): multiple definition of `file_formats'; /var/tmp/portage/media-sound/wavegain-1.3.1/temp/cci4ockk.o:(.bss+0x8): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/media-sound/wavegain-1.3.1/temp/ccq97bBi.o:(.bss+0x148): multiple definition of `file_formats'; /var/tmp/portage/media-sound/wavegain-1.3.1/temp/cci4ockk.o:(.bss+0x8): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no-multilib-20200124-204141

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *


llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.40.0 *



repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Mon, 27 Jan 2020 06:46:16 +0000

emerge -qpvO media-sound/wavegain
[ebuild  N    ] media-sound/wavegain-1.3.1
Comment 1 Toralf Förster gentoo-dev 2020-01-27 17:33:38 UTC
Created attachment 605380 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-27 17:33:41 UTC
Created attachment 605382 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-27 17:33:44 UTC
Created attachment 605384 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-27 17:33:46 UTC
Created attachment 605386 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-27 17:33:49 UTC
Created attachment 605388 [details]
media-sound:wavegain-1.3.1:20200127-073350.log
Comment 6 Toralf Förster gentoo-dev 2020-01-27 17:33:52 UTC
Created attachment 605390 [details]
temp.tbz2
Comment 7 Matt Whitlock 2020-05-16 02:26:27 UTC
Created attachment 639490 [details, diff]
fix-for-fno-common.patch

The attached patch fixes the immediate issue. (Numerious other code quality issues remain.)
Comment 8 Jonas Stein gentoo-dev 2020-07-04 18:23:49 UTC
linked also to
https://github.com/MestreLion/wavegain/issues/7
I am undecided, if this is a better SRC_URI
Comment 9 Larry the Git Cow gentoo-dev 2020-08-08 16:54:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ad99e9ec198ceac774013a65828ed92e81fdfee

commit 9ad99e9ec198ceac774013a65828ed92e81fdfee
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-08-08 16:53:24 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-08-08 16:53:24 +0000

    media-sound/wavegain: Fix building under -fno-common
    
    Closes: https://bugs.gentoo.org/706692
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../wavegain/files/wavegain-1.3.1-fno-common.patch        | 11 +++++++++++
 media-sound/wavegain/files/wavegain-1.3.1-makefile.patch  |  7 +++++++
 media-sound/wavegain/wavegain-1.3.1.ebuild                | 15 +++++++++------
 3 files changed, 27 insertions(+), 6 deletions(-)