Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706212 - sys-devel/crossdev: use package.accept_keywords instead of package.keywords
Summary: sys-devel/crossdev: use package.accept_keywords instead of package.keywords
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Crossdev team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 607852
  Show dependency tree
 
Reported: 2020-01-23 23:42 UTC by Doppler
Modified: 2020-01-25 21:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doppler 2020-01-23 23:42:16 UTC
The crossdev script has yet to switch from package.keywords to package.accept_keywords, and now that the former is being deprecated, users (at least on ~arch?) who use crossdev are likely to start seeing messages such as:

/usr/lib/python3.8/site-packages/portage/package/ebuild/_config/KeywordsManager.py:67: UserWarning: /etc/portage/package.keywords is deprecated, use /etc/portage/package.accept_keywords instead

As such, it would be nice for it to start adding any required keywords to package.accept_keywords instead soon.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2020-01-24 23:06:39 UTC
Yeah we should fix it.

The minor annoyance is that crossdev not just adds keywords but also removes them to pick CTARGET's KEYWORDS instead of CHOST's KEYWORDS for gcc and friends.

accept_keywords should still allow it but semantics might be slightly different.
Comment 2 Larry the Git Cow gentoo-dev 2020-01-25 21:17:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=44dc00f87317dc5697da14bc9e8e9540c670dbc0

commit 44dc00f87317dc5697da14bc9e8e9540c670dbc0
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-01-25 21:11:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-01-25 21:11:11 +0000

    crossdev: migrate from package.keywords to package.accept_keywords
    
    Reported-by: Doppler
    Bug: https://bugs.gentoo.org/706212
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 crossdev | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2020-01-25 21:45:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=385f248b765e327e6eccaf423c55e0f2f82a3e4b

commit 385f248b765e327e6eccaf423c55e0f2f82a3e4b
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-01-25 21:45:35 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-01-25 21:45:48 +0000

    sys-devel/crossdev: bump up to 20200125
    
    Two new changes:
    - disable default ssp support on x86 and ppc on musl, bug #706210
    - migrate from package.keywords to package.accept_keywords, bug #706212
    
    Bug: https://bugs.gentoo.org/706210
    Closes: https://bugs.gentoo.org/706212
    Package-Manager: Portage-2.3.85, Repoman-2.3.20
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/crossdev/Manifest                 |  1 +
 sys-devel/crossdev/crossdev-20200125.ebuild | 36 +++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)