Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705276 - =sys-cluster/corosync-2.4.2 uses lexicographical version compare
Summary: =sys-cluster/corosync-2.4.2 uses lexicographical version compare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 705240
  Show dependency tree
 
Reported: 2020-01-12 11:49 UTC by Sergei Trofimovich
Modified: 2020-05-05 21:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich gentoo-dev 2020-01-12 11:49:25 UTC
sys-cluster/corosync uses lexicographical string version compare:

sys-cluster/corosync/corosync-2.3.5.ebuild:	if [[ ${REPLACING_VERSIONS} < 2.0 ]]; then
sys-cluster/corosync/corosync-2.4.2.ebuild:	if [[ ${REPLACING_VERSIONS} < 2.0 ]]; then

The intention is likely to use 'ver_cmp'. See bug #705240 for hints to fix it.
Comment 1 Larry the Git Cow gentoo-dev 2020-05-05 21:46:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2bd0ad359f6b217b1e8c1da7956eb54addfa355

commit d2bd0ad359f6b217b1e8c1da7956eb54addfa355
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-05-05 21:46:02 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-05-05 21:46:13 +0000

    sys-cluster/corosync: drop invalid version check, bug #705276
    
    'if [[ ${REPLACING_VERSIONS} < 2.0 ]]; then' uses lexicographical
    version compare. That should be ver_cmp version compare or similar.
    
    As it's a guard against non-existent version let's just drop the ewarn.
    
    Closes: https://bugs.gentoo.org/705276
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-cluster/corosync/corosync-2.3.5.ebuild | 11 -----------
 sys-cluster/corosync/corosync-2.4.2.ebuild | 11 -----------
 2 files changed, 22 deletions(-)