Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705254 - =games-action/openclonk-7.0 uses lexicographical version compare
Summary: =games-action/openclonk-7.0 uses lexicographical version compare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 705240
  Show dependency tree
 
Reported: 2020-01-12 11:19 UTC by Sergei Trofimovich
Modified: 2020-02-18 14:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich gentoo-dev 2020-01-12 11:19:08 UTC
games-action/openclonk uses lexicographical string version compare:

games-action/openclonk/openclonk-7.0.ebuild:	if [[ $(tc-getCXX) == *g++* && $(gcc-version) < 4.9 ]] ; then

The intention is likely to use 'ver_cmp'. See bug #705240 for hints to fix it.
Comment 1 Larry the Git Cow gentoo-dev 2020-02-18 14:40:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5826fd14fa4f2cfb27fab52fa6fbf8a8483badd4

commit 5826fd14fa4f2cfb27fab52fa6fbf8a8483badd4
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-02-18 14:40:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-02-18 14:40:15 +0000

    games-action/openclonk: drop outdated compiler check, bug #705254
    
    Avoid lexicographical compare in pkg_setup().
    
    Closes: https://bugs.gentoo.org/705254
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 games-action/openclonk/openclonk-7.0.ebuild | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)