Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705250 - portability.eclass uses lexicographical compare
Summary: portability.eclass uses lexicographical compare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 705240
  Show dependency tree
 
Reported: 2020-01-12 11:16 UTC by Sergei Trofimovich
Modified: 2020-02-18 14:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich gentoo-dev 2020-01-12 11:16:27 UTC
portability.eclass uses lexicographical string compare:

eclass/portability.eclass:		[[ $max < $min && $step > 0 ]] && break
eclass/portability.eclass:		[[ $min < $max && $step < 0 ]] && break

The intention is likely to use '-lt'. See bug #705240 for hints to fix it.
Comment 1 Larry the Git Cow gentoo-dev 2020-02-18 14:32:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a05e3a4ad8c8948465e22509b356e191b90789a

commit 1a05e3a4ad8c8948465e22509b356e191b90789a
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-02-18 14:30:43 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-02-18 14:31:45 +0000

    portability.eclass: avoid lexicographic number comparison, bug #705250
    
    Closes: https://bugs.gentoo.org/705250
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 eclass/portability.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)