Created attachment 602902 [details, diff] tested ebuild patch Calibre now uses BeautifulSoup of version 4 and above, and scripts use bs4 API as well. Also now file src/calibre/ebooks/BeautifulSoup.py just imports system bs4, so no need to apply "sed -e 's/calibre.ebooks.BeautifulSoup/BeautifulSoup/'" anymore. Currently the error is reported: Traceback (most recent call last): File "/usr/lib64/calibre/calibre/gui2/book_details.py", line 897, in show_data self.book_info.show_data(data) File "/usr/lib64/calibre/calibre/gui2/book_details.py", line 623, in show_data html = render_html(mi, self.vertical, self.parent()) File "/usr/lib64/calibre/calibre/gui2/book_details.py", line 109, in render_html use_roman_numbers=config['use_roman_numerals_for_series_number']) File "/usr/lib64/calibre/calibre/gui2/book_details.py", line 166, in render_data comments_heading_pos=gprefs['book_details_comments_heading_pos'] File "/usr/lib64/calibre/calibre/ebooks/metadata/book/render.py", line 137, in mi_to_html val = comments_to_html(val) File "/usr/lib64/calibre/calibre/library/comments.py", line 104, in comments_to_html pTag = result.new_tag('p') TypeError: 'NoneType' object is not callable
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b0068ce396d2c44e43bc5675062db7e15e51da36 commit b0068ce396d2c44e43bc5675062db7e15e51da36 Author: Rayslava <rayslava@gmail.com> AuthorDate: 2020-01-12 01:27:45 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-01-12 01:40:03 +0000 app-text/calibre: Revbump to 4.8.0-r1 for bug 602902 Depend on beautifulsoup:4 and html5-parser-0.4.9. Closes: https://bugs.gentoo.org/705088 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org> .../calibre/{calibre-4.8.0.ebuild => calibre-4.8.0-r1.ebuild} | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
Thanks!
The bug report is incorrect -- *all* versions of calibre since March 2019 are affected, since calibre-3.41.0 is the first version that was ported to beautifulsoup4 (and which the incorrect sed escalated to breaking calibre). Please fix this bug for all versions of calibre you ship, since all of them are affected, or else delete the broken versions from your recipes tree.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6efccd409cc68bb92027bc9cb49c82fcc84e56f9 commit 6efccd409cc68bb92027bc9cb49c82fcc84e56f9 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2020-01-13 01:54:01 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-01-13 02:15:13 +0000 app-text/calibre: Remove old version 3.47.1 for bug 705088 This version has broken beautifulsoup support as reported by Eli Schwartz in bug 705088. It's fixed in 3.48.0-r1. Reported-by: Eli Schwartz <eschwartz@archlinux.org> Bug: https://bugs.gentoo.org/705088#c3 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org> app-text/calibre/Manifest | 1 - app-text/calibre/calibre-3.47.1.ebuild | 268 --------------------------------- 2 files changed, 269 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=477828e0d50d1f05f0eb08991777785946c74ff2 commit 477828e0d50d1f05f0eb08991777785946c74ff2 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2020-01-13 01:24:45 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-01-13 02:15:13 +0000 app-text/calibre: Revbump to 3.48.0-r1 and stabilize for bug 705088 Depend on beautifulsoup:4 and html5-parser-0.4.9 and stabilize this version since version 3.47.1 has broken beautifulsoup support as reported by Eli Schwartz in bug 705088. Reported-by: Eli Schwartz <eschwartz@archlinux.org> Bug: https://bugs.gentoo.org/705088#c3 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org> .../{calibre-3.48.0.ebuild => calibre-3.48.0-r1.ebuild} | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ef3fe8391f810ede0e19cfb3d1811709bacc607 commit 2ef3fe8391f810ede0e19cfb3d1811709bacc607 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2020-01-13 01:24:45 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-01-13 02:15:13 +0000 app-text/calibre: Revbump to 4.7.0-r1 for bug 705088 Depend on beautifulsoup:4 and html5-parser-0.4.9. Reported-by: Eli Schwartz <eschwartz@archlinux.org> Bug: https://bugs.gentoo.org/705088#c3 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org> .../{calibre-4.7.0.ebuild => calibre-4.7.0-r1.ebuild} | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de4a6242aaedfa7f2eb3f18eb0c2ffaee1b7e170 commit de4a6242aaedfa7f2eb3f18eb0c2ffaee1b7e170 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2020-01-13 01:43:29 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-01-13 02:15:12 +0000 dev-python/html5-parser: Stabilize 0.4.9 for bug 705088 Needed for compat with latest stable dev-python/beautifulsoup. Bug: https://bugs.gentoo.org/705088#c3 Bug: https://bugs.gentoo.org/705090 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org> dev-python/html5-parser/html5-parser-0.4.9.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Eli!
