Created attachment 602430 [details, diff] netifrc-0.6.1-pppd-2.4.8-defaultroute-metric.patch In URL pppd got a new option called "defaultroute-metric". This is the same like we used to patch into older ppp releases but with a different name. old name (was patched into <2.4.8 releases by us): defaultmetric new name (sinde 2.4.8 release): defaultroute-metric Now of course, netifrc's net/pppd.sh script calls pppd with wrong option and pppd refuses to start. The attached patch should fix this. I'm not very happy with the version check function so feel free to request something more elegant (but please give me a hint what I should change). As long as this has not been fixed and published in a new netifrc release, I cannot fix bug #704680 and thus not bump to ppp-2.4.8 version.
Created attachment 602432 [details, diff] netifrc-0.6.1-pppd-2.4.8-defaultroute-metric.patch Same patch just with quoting in patch summary fixed.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=9472b0e2fd402819963f492fe9ba37c82c0de277 commit 9472b0e2fd402819963f492fe9ba37c82c0de277 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2020-01-03 20:30:28 +0000 Commit: Robin H. Johnson <robbat2@gentoo.org> CommitDate: 2020-01-04 07:58:21 +0000 pppd.sh: ppp-2.4.8 introduced "defaultroute-metric" option That option name differs from the one we patched into previous pppd releases so check if we are on >=2.4.8 version and use the correct option name accordingly Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> Closes: https://bugs.gentoo.org/704722 Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> net/pppd.sh | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7289053524cb088c87ea7a9c88ad5a631978d03f commit 7289053524cb088c87ea7a9c88ad5a631978d03f Author: Robin H. Johnson <robbat2@gentoo.org> AuthorDate: 2020-01-04 08:15:40 +0000 Commit: Robin H. Johnson <robbat2@gentoo.org> CommitDate: 2020-01-04 08:16:55 +0000 net-misc/netifrc: bump Major changes: - init.d/net.lo: add a configurable presence timeout - net/veth: new functionality Fixes: - net/wireguard: sync - net/ppp: support ppp-2.4.8 - *: lots of shellcheck fixes Package-Manager: Portage-2.3.83, Repoman-2.3.18 Closes: https://bugs.gentoo.org/704722 Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> net-misc/netifrc/Manifest | 1 + net-misc/netifrc/netifrc-0.2.2.ebuild | 2 +- net-misc/netifrc/netifrc-0.2.3.ebuild | 2 +- net-misc/netifrc/netifrc-0.2.4.ebuild | 2 +- net-misc/netifrc/netifrc-0.3.0.ebuild | 2 +- net-misc/netifrc/netifrc-0.3.1.ebuild | 2 +- net-misc/netifrc/netifrc-0.4.0-r1.ebuild | 2 +- net-misc/netifrc/netifrc-0.4.0.ebuild | 2 +- net-misc/netifrc/netifrc-0.5.0.ebuild | 2 +- net-misc/netifrc/netifrc-0.5.1.ebuild | 2 +- net-misc/netifrc/netifrc-0.6.0.ebuild | 2 +- net-misc/netifrc/netifrc-0.6.1.ebuild | 2 +- net-misc/netifrc/netifrc-0.7.1.ebuild | 71 ++++++++++++++++++++++++++++++++ net-misc/netifrc/netifrc-9999.ebuild | 8 ++-- 14 files changed, 87 insertions(+), 15 deletions(-)
Would it not make sense to introduce a defaultmetric alias in pppd 2.4.8? Stabling netifrc seems to take very long
(In reply to Joakim Tjernlund from comment #4) > Would it not make sense to introduce a defaultmetric alias in pppd 2.4.8? > Stabling netifrc seems to take very long I'm working o that. But my C knowledge is quite rusty so it may take a while till I have a satisfying result.
