I updated to Dovecot 2.3.9 and was presented with the following message: >>> Installing (5 of 5) net-mail/dovecot-2.3.9::gentoo Please read https://wiki2.dovecot.org/Upgrading/ for upgrade notes. Messages for package acct-user/dovenull-0: There was an error when attempting to update the groups for dovenull Please update it manually on your system (as root): usermod -g dovenull -G "dovenull" The above usermod statement is syntactically incorrect. I assume that usermod -g dovenull -G "" dovenull it what was actually intended here.
That message is written by acct-user.eclass.
(In reply to Jeroen Roovers from comment #1) > That message is written by acct-user.eclass. No, user.eclass...
I suspect we could make it: "usermod" "-g" "dovenull" "-G" "" "dovenull" without too much effort. Getting beyond that would probably be an overkill. That said, is there a deeper bug that the update didn't work for you, or did you figure that out?
(In reply to Michał Górny from comment #3) > "usermod" "-g" "dovenull" "-G" "" "dovenull" I did notice the extra space in the error message, so I assumed it was due to the lack of quoting the group name (which in this case is empty). > is there a deeper bug that the update didn't work > for you, or did you figure that out? No deeper bug, thanks. The intended statement only strips user dovenull of any secondary groups. All is well. ;-)
(In reply to Ralph Seichter from comment #4) > (In reply to Michał Górny from comment #3) > > > "usermod" "-g" "dovenull" "-G" "" "dovenull" > I did notice the extra space in the error message, so I assumed it was due > to the lack of quoting the group name (which in this case is empty). Yes. So, do you think I should change it to safely overquote? > > > is there a deeper bug that the update didn't work > > for you, or did you figure that out? > No deeper bug, thanks. The intended statement only strips user dovenull of > any secondary groups. All is well. ;-) I meant: why didn't the eclass correctly update it itself, and asked you to do it instead?
I think that correctness beats "looking pretty" every time when generated commands are the subject. Superfluous quotes are therefore fine by me.
Actually, I've found a better solution: printf builtin has '%q' format that takes care of quoting as necessary. So something like: set -- command arg "${foo}" "${bar}" "${@}" && return 0 # ... ewarn " $(printf '%q ' "${@}")" should get the call reprinted with quoting/escapes added where necessary.
Bump.
user.eclass has been removed from the gentoo repo.
