Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 700308 - x11-libs/libX11 USE=doc should not depend on app-doc/doxygen
Summary: x11-libs/libX11 USE=doc should not depend on app-doc/doxygen
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-17 01:53 UTC by Adam Purkrt
Modified: 2022-04-02 19:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Purkrt 2019-11-17 01:53:24 UTC
When installing x11-libs/libX11 with the 'doc' USE flag, app-doc/doxygen is pulled in; it should not.

I tried
emerge -C app-doc/doxygen
emerge -1 --nodepse x11-libs/libX11
and it works.
Comment 1 Ionen Wolkens gentoo-dev 2019-11-17 02:18:51 UTC
Does seem like a useless dependency, it's defined by xorg-3.eclass, but I can't find anything in the libX11 package actually using doxygen (unlike xorg-server itself). I believe all that's needed here is to remove the "XORG_DOC=doc" line, unless there's some other dependencies I'm not seeing.
Comment 2 Ionen Wolkens gentoo-dev 2019-11-17 02:37:22 UTC
(In reply to Ionen Wolkens from comment #1)
> unless there's some other dependencies I'm not seeing
And right, at the very least xmlto does need, well, xmlto (which xorg-3 defines). So I guess if want to omit doxygen will need a separate doc depend entry. Unless really want to keep the unified style.
Comment 3 Matt Turner gentoo-dev 2019-11-18 05:32:17 UTC
(In reply to Ionen Wolkens from comment #1)
> Does seem like a useless dependency, it's defined by xorg-3.eclass, but I
> can't find anything in the libX11 package actually using doxygen (unlike
> xorg-server itself). I believe all that's needed here is to remove the
> "XORG_DOC=doc" line, unless there's some other dependencies I'm not seeing.

Interesting. If we can confirm that it's only xorg-server that needs doxygen for USE=doc, I can fix this easily.
Comment 4 Matt Turner gentoo-dev 2019-11-18 19:15:41 UTC
(Is anyone interested in doing the leg work to confirm that it's only xorg-server that needs doxygen out of all the packages that have IUSE=doc and inherit xorg-2 or xorg-3?)
Comment 5 Adam Purkrt 2019-11-18 20:02:22 UTC
Here's what I did to find all the xorg-2 and xorg-3 inheriting packages that has doc use flag (hopefully):

cd /var/db/repos/gentoo
find -type f -name "*.ebuild" | xargs -n1 grep -l xorg-2 > $HOME/xorg-2-inherit
find -type f -name "*.ebuild" | xargs -n1 grep -l xorg-3 > $HOME/xorg-3-inherit
cat $HOME/xorg-2-inherit $HOME/xorg-3-inherit | xargs grep -l "doc" > $HOME/docpkgs

the result - cat $HOME/docpkgs:

./x11-libs/libXaw/libXaw-1.0.13-r1.ebuild
./x11-libs/libXtst/libXtst-1.2.3-r1.ebuild
./x11-libs/startup-notification/startup-notification-0.12-r1.ebuild
./x11-libs/xcb-util-image/xcb-util-image-0.4.0-r1.ebuild
./x11-libs/xcb-util/xcb-util-0.4.0-r1.ebuild
./x11-libs/xcb-util-cursor/xcb-util-cursor-0.1.3-r2.ebuild
./x11-libs/libSM/libSM-1.2.3.ebuild
./x11-libs/libxcb/libxcb-1.13.1.ebuild
./x11-libs/xcb-util-keysyms/xcb-util-keysyms-0.4.0-r1.ebuild
./x11-libs/xcb-util-wm/xcb-util-wm-0.4.1-r2.ebuild
./x11-libs/xcb-util-xrm/xcb-util-xrm-1.3.ebuild
./x11-libs/xcb-util-xrm/xcb-util-xrm-1.2.ebuild
./x11-libs/xcb-util-xrm/xcb-util-xrm-1.0.ebuild
./x11-libs/xcb-util-renderutil/xcb-util-renderutil-0.3.9-r2.ebuild
./x11-libs/libxkbcommon/libxkbcommon-0.8.4.ebuild
./x11-libs/libXi/libXi-1.7.10.ebuild
./x11-libs/libXcursor/libXcursor-1.2.0.ebuild
./x11-libs/libXcomposite/libXcomposite-0.4.5.ebuild
./x11-libs/libICE/libICE-1.0.10.ebuild
./x11-libs/libXdmcp/libXdmcp-1.1.3.ebuild
./x11-libs/libX11/libX11-1.6.9.ebuild
./x11-libs/libX11/libX11-1.6.8.ebuild
./x11-libs/libXfont2/libXfont2-9999.ebuild
./x11-libs/libXfont2/libXfont2-2.0.4.ebuild
./x11-libs/libXxf86dga/libXxf86dga-1.1.5.ebuild
./x11-libs/libXmu/libXmu-1.1.3.ebuild
./x11-libs/xtrans/xtrans-1.4.0.ebuild
./x11-libs/libXrandr/libXrandr-1.5.2.ebuild
./x11-libs/libXext/libXext-1.3.4.ebuild
./x11-libs/libXft/libXft-2.3.3.ebuild
./x11-libs/libXt/libXt-1.2.0.ebuild
./x11-base/xorg-server/xorg-server-1.20.5.ebuild
./x11-base/xorg-server/xorg-server-9999.ebuild

So now "only" to test if the packages build without doxygen; that should not be too hard.
Comment 6 Adam Purkrt 2019-11-18 20:31:13 UTC
emerge -C app-doc/doxygen
for file in $(cat /root/docpkgs); do USE=doc ebuild $file compile || echo $file >> /root/docpkgs-needs-doxygen; ebuild $file clean; done

the result - cat /root/docpkgs-needs-doxygen:

./x11-libs/xcb-util-image/xcb-util-image-0.4.0-r1.ebuild
./x11-libs/xcb-util/xcb-util-0.4.0-r1.ebuild
./x11-libs/xcb-util-cursor/xcb-util-cursor-0.1.3-r2.ebuild
./x11-libs/xcb-util-keysyms/xcb-util-keysyms-0.4.0-r1.ebuild
./x11-libs/xcb-util-wm/xcb-util-wm-0.4.1-r2.ebuild
./x11-libs/xcb-util-renderutil/xcb-util-renderutil-0.3.9-r2.ebuild
./x11-libs/libxkbcommon/libxkbcommon-0.8.4.ebuild
./x11-base/xorg-server/xorg-server-1.20.5.ebuild
./x11-base/xorg-server/xorg-server-9999.ebuild
Comment 7 Nguyen Thai Ngoc Duy 2021-03-25 09:54:35 UTC
Ping... any way forward with this?
Comment 8 Larry the Git Cow gentoo-dev 2021-12-16 02:37:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8778b79096ac5a2a9c824345204a1ba92e16ccc4

commit 8778b79096ac5a2a9c824345204a1ba92e16ccc4
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2021-12-16 01:30:51 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2021-12-16 02:37:22 +0000

    x11-base/xorg-server: Remove IUSE=doc
    
    Not sure if this ever installed anything useful. Developer docs were not
    installed because it needed the fop utility.
    
    Bug: https://bugs.gentoo.org/700308
    Closes: https://bugs.gentoo.org/827976
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-base/xorg-server/xorg-server-9999.ebuild | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
Comment 9 Matt Turner gentoo-dev 2022-04-02 19:39:52 UTC
(In reply to Adam Purkrt from comment #6)
> emerge -C app-doc/doxygen
> for file in $(cat /root/docpkgs); do USE=doc ebuild $file compile || echo
> $file >> /root/docpkgs-needs-doxygen; ebuild $file clean; done
> 
> the result - cat /root/docpkgs-needs-doxygen:

Thanks a bunch!

> ./x11-libs/xcb-util-image/xcb-util-image-0.4.0-r1.ebuild
> ./x11-libs/xcb-util/xcb-util-0.4.0-r1.ebuild
> ./x11-libs/xcb-util-cursor/xcb-util-cursor-0.1.3-r2.ebuild
> ./x11-libs/xcb-util-keysyms/xcb-util-keysyms-0.4.0-r1.ebuild
> ./x11-libs/xcb-util-wm/xcb-util-wm-0.4.1-r2.ebuild
> ./x11-libs/xcb-util-renderutil/xcb-util-renderutil-0.3.9-r2.ebuild

Looks like I dropped XORG_DOC=doc from these.

> ./x11-libs/libxkbcommon/libxkbcommon-0.8.4.ebuild

No longer uses xorg-3.eclass.

> ./x11-base/xorg-server/xorg-server-1.20.5.ebuild
> ./x11-base/xorg-server/xorg-server-9999.ebuild

Dropped XORG_DOC=doc per comment #8.
Comment 10 Larry the Git Cow gentoo-dev 2022-04-02 19:51:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b9d890e82c4ae09770a48c33373c17c69046794

commit 5b9d890e82c4ae09770a48c33373c17c69046794
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-02 19:31:41 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-02 19:51:21 +0000

    xorg-3.eclass: Drop app-doc/doxygen as a doc dependency
    
    Closes: https://bugs.gentoo.org/700308
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 eclass/xorg-3.eclass | 1 -
 1 file changed, 1 deletion(-)