Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699494 - games-puzzle/angrydd: dosym with path starting with ${ED}
Summary: games-puzzle/angrydd: dosym with path starting with ${ED}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-07 00:41 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-07 21:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-11-07 00:41:27 UTC
games-puzzle/angrydd/angrydd-1.0.1-r2.ebuild:   dosym "${ED}/usr/share/${PN}/angrydd.py" "/usr/bin/${PN}"


Problems with above dosym command:

1. Initial ${D} or ${ED} is unnecessary in first argument (target of symbolic link), and PMS-compliant package managers will issue QA notice.
   PMS (https://projects.gentoo.org/pms/7/pms.html#x1-14800013.4.1):
   """
   13.4.1 Rewriting

   Any absolute symlink whose link starts with D must be rewritten with
   the leading D removed. The package manager should issue a notice when doing this. 
   """

2. Target of symbolic link could be made relative, instead of absolute.


Solution:

dosym "../share/${PN}/angrydd.py" "/usr/bin/${PN}"
Comment 1 Larry the Git Cow gentoo-dev 2019-11-07 21:37:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80d5df7cfad77d7315092ba706e551838c51bbc6

commit 80d5df7cfad77d7315092ba706e551838c51bbc6
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2019-11-07 21:36:36 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-11-07 21:36:36 +0000

    games-puzzle/angrydd: Fix use of dosym with ${ED}
    
    Closes: https://bugs.gentoo.org/699494
    Package-Manager: Portage-2.3.78, Repoman-2.3.17
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-puzzle/angrydd/angrydd-1.0.1-r2.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 James Le Cuirot gentoo-dev 2019-11-07 21:37:45 UTC
Thanks, although this package will probably die with Python 2.