Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 697538 - x11-drivers/nvidia-drivers: /lib/udev/rules.d/99-nvidia-uvm.rules:1 Invalid value "/bin/bash -c '/bin/mknod -m 660 /dev/nvidia-uvm c $(grep nvidia-uvm /proc/devices | cut -d \ -f 1) 0; /bin/chgrp vide
Summary: x11-drivers/nvidia-drivers: /lib/udev/rules.d/99-nvidia-uvm.rules:1 Invalid v...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-12 08:00 UTC by poncho
Modified: 2019-11-29 01:59 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description poncho 2019-10-12 08:00:35 UTC
systemd-udevd[771]: /lib/udev/rules.d/99-nvidia-uvm.rules:1 Invalid value "/bin/bash -c '/bin/mknod -m 660 /dev/nvidia-uvm c $(grep nvidia-uvm /proc/devices | cut -d \  -f 1) 0; /bin/chgrp video /dev/nvidia-uvm'" for RUN (char 51: invalid substitution type), ignoring, but please fix it.

This warning appears after the update to sys-apps/systemd-243
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-10-15 16:56:50 UTC
*** Bug 697774 has been marked as a duplicate of this bug. ***
Comment 2 Mike Gilbert gentoo-dev 2019-10-15 17:41:20 UTC
Please report the issue to systemd upstream. Include the text of the relevant udev rule(s).
Comment 3 poncho 2019-10-15 17:45:28 UTC
(In reply to Mike Gilbert from comment #2)
> Please report the issue to systemd upstream. Include the text of the
> relevant udev rule(s).

lvm and networkmanager have fixes in their upstream git repos.

the nvidia driver rule I've reported the issue for is gentoo specific. (installed from FILESDIR)
Comment 4 Mike Gilbert gentoo-dev 2019-10-15 17:58:42 UTC
Giving this back to the nvidia-drivers maintainer then.

According to udev(7), dollar signs should be escaped with another dollar sign.

       The NAME, SYMLINK, PROGRAM, OWNER, GROUP, MODE, SECLABEL, and RUN
       fields support simple string substitutions. The RUN substitutions are
       performed after all rules have been processed, right before the program
       is executed, allowing for the use of device properties set by earlier
       matching rules. For all other fields, substitutions are performed while
       the individual rule is being processed. The available substitutions
       are:

...

       $$
           The "$" character itself.
Comment 5 Mike Gilbert gentoo-dev 2019-10-15 18:26:55 UTC
For reference, I believe additional error checking was added to udev as part of this PR. The documentation regarding this has not been changed in several years.

https://github.com/systemd/systemd/pull/12700
Comment 6 poncho 2019-10-15 18:44:03 UTC
(In reply to poncho from comment #3)
> lvm and networkmanager have fixes in their upstream git repos.

https://sourceware.org/git/?p=lvm2.git;a=commit;h=125f27ac37bc9b93cc96f64052b9681b3d479ee1

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/27d380b70ea839c7badab420361e4e65e023e8e9

those are the commits mentioned before
Comment 7 Larry the Git Cow gentoo-dev 2019-11-29 01:59:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4c7b2f1e880a4795ee529180369f60658f565f2

commit f4c7b2f1e880a4795ee529180369f60658f565f2
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-11-29 01:57:48 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-11-29 01:57:48 +0000

    x11-drivers/nvidia-drivers: fix udev rule syntax
    
    Closes: https://bugs.gentoo.org/697538
    Package-Manager: Portage-2.3.79_p3, Repoman-2.3.18_p2
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 x11-drivers/nvidia-drivers/files/nvidia-uvm.udev-rule                   | 2 +-
 .../{nvidia-drivers-390.129.ebuild => nvidia-drivers-390.129-r1.ebuild} | 0
 .../{nvidia-drivers-390.132.ebuild => nvidia-drivers-390.132-r1.ebuild} | 0
 .../{nvidia-drivers-430.64.ebuild => nvidia-drivers-430.64-r1.ebuild}   | 0
 .../{nvidia-drivers-435.21.ebuild => nvidia-drivers-435.21-r1.ebuild}   | 0
 .../{nvidia-drivers-440.31.ebuild => nvidia-drivers-440.31-r1.ebuild}   | 0
 .../{nvidia-drivers-440.36.ebuild => nvidia-drivers-440.36-r1.ebuild}   | 0
 7 files changed, 1 insertion(+), 1 deletion(-)