Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 696832 - [QA] Ban RESTRICT=primaryuri from ::gentoo
Summary: [QA] Ban RESTRICT=primaryuri from ::gentoo
Status: CONFIRMED
Alias: None
Product: Quality Assurance
Classification: Unclassified
Component: Policies (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard: vote [y/n/a]: 5/0/0
Keywords:
Depends on: 696826 696828 696830
Blocks:
  Show dependency tree
 
Reported: 2019-10-06 07:41 UTC by Michał Górny
Modified: 2021-07-21 01:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-10-06 07:41:22 UTC
I don't think we have a valid use case for this RESTRICT.  Devmanual tries hard to come up with something:

| this is sometimes useful if approximate download counts are needed,
| or if upstream have a reliable mirror setup.

The first argument is silly -- for redistributable stuff, downloads counts are meaningless.  The second contradicts what it says earlier -- if stuff gets distributed to Gentoo mirrors, there's no reason not to use them.

We have exactly three packages using this right now.  I've filed bugs for all of them to learn why the maintainers enabled it.
Comment 1 Ulrich Müller gentoo-dev 2019-10-07 06:49:34 UTC
PMS doesn't mention this, therefore removing pms@ from CC.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-02 07:51:26 UTC
Ok, there's a last consumer left, devmanual has been updated and nobody brought any new argument why this is necessary.  Therefore I'd like to call a vote.

Vote: ban RESTRICT=primaryuri in ::gentoo (removed it from allowed RESTRICT list)
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2019-11-02 08:15:44 UTC
I vote yes.
Comment 4 Ulrich Müller gentoo-dev 2019-11-02 08:59:36 UTC
Do we even have to vote on this? As I said in comment #1, primaryuri is not mentioned by the spec, so ebuilds cannot rely on its being supported.

(In case we do, I vote yes.)
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2019-11-02 11:15:17 UTC
yes
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-02 11:40:11 UTC
aye
Comment 7 Larry the Git Cow gentoo-dev 2019-11-02 11:45:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c74fb98c07aa4bf07dfc3974de5549b3a28cf3ca

commit c74fb98c07aa4bf07dfc3974de5549b3a28cf3ca
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-11-02 11:43:02 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-11-02 11:43:02 +0000

    metadata/layout.conf: Disallow RESTRICT=primaryuri
    
    Bug: https://bugs.gentoo.org/696832
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 metadata/layout.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 8 Sergey Popov gentoo-dev 2019-11-06 07:57:51 UTC
Never used it, did not know that it was a thing...

So, yes from me too, if it matters...