Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 694382 - dev-go/delve: incomplete LICENSE
Summary: dev-go/delve: incomplete LICENSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2019-12-05
Assignee: g4s8.public
URL:
Whiteboard:
Keywords: PMASKED, PullRequest
Depends on:
Blocks: 694792
  Show dependency tree
 
Reported: 2019-09-14 20:45 UTC by Michał Górny
Modified: 2019-11-07 05:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-14 20:45:39 UTC
$ find -name '*LICENSE*' -exec ninka {} ';'
./vendor/gopkg.in/yaml.v2/LICENSE.libyaml;spdxMIT;1;4;0;1;1;UNKNOWN,Copyright,4
./vendor/gopkg.in/yaml.v2/LICENSE;Apache-2;1;5;0;1;0;Copyright,5
./vendor/golang.org/x/sys/LICENSE;spdxBSD3;1;6;1;1;0;Copyright,-1,6
./vendor/golang.org/x/arch/LICENSE;spdxBSD3;1;6;1;1;0;Copyright,-1,6
./vendor/github.com/spf13/pflag/LICENSE;spdxBSD3;1;6;2;2;0;Copyright,-1,Copyright,-1,6
./vendor/github.com/pkg/profile/LICENSE;spdxBSD2;1;5;1;1;0;Copyright,-1,5
./vendor/github.com/mattn/go-isatty/LICENSE;spdxMIT;1;4;0;2;0;Copyright,MITname,4
./vendor/github.com/mattn/go-colorable/LICENSE;spdxMIT;1;4;0;2;0;MITname,Copyright,4
./vendor/github.com/inconshreveable/mousetrap/LICENSE;Apache-2;1;5;0;1;0;Copyright,5
./vendor/github.com/cpuguy83/go-md2man/LICENSE.md;spdxMIT;1;4;0;2;0;MITname,Copyright,4
./vendor/github.com/cosiner/argv/LICENSE;spdxMIT;1;4;0;2;0;MITname,Copyright,4
./LICENSE;spdxMIT;1;4;0;2;0;MITname,Copyright,4

So the project bundles components using: MIT, Apache-2.0, BSD, BSD-2 licenses.  Since all of them are more restrictive than project's MIT license, they should all be listed in LICENSE.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-03 19:59:00 UTC
Ping.
Comment 2 Larry the Git Cow gentoo-dev 2019-11-05 18:43:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8084b92184cfe5bbdf82b177e0ab00b719d494d9

commit 8084b92184cfe5bbdf82b177e0ab00b719d494d9
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-11-05 18:41:42 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-11-05 18:41:43 +0000

    package.mask: Last rite app-admin/{certmgr,ksonnet}, dev-go/delve
    
    Bug: https://bugs.gentoo.org/694382
    Bug: https://bugs.gentoo.org/694690
    Bug: https://bugs.gentoo.org/694710
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Comment 3 OzTiram 2019-11-06 06:01:32 UTC
Please don't remove this package.
This package is marked as having no maintainer, but the last version 1.3.0 has one. Except that there in no proxy-maintainer issue for him.

I am willing to help the maintainer to take good care of this package.

Finally, the latest ebuilds (1.3.0 and the one pending in PR 1.3.2) have fixed
the issue and the license line is:

LICENSE="MIT BSD BSD-2 Apache-2.0"
Comment 4 OzTiram 2019-11-06 06:10:51 UTC
See upstream bug:

https://github.com/go-delve/delve/issues/1743
Comment 5 Larry the Git Cow gentoo-dev 2019-11-06 06:23:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a6e2a7ebba1cf11a6f9642364a2b743ec106834

commit 2a6e2a7ebba1cf11a6f9642364a2b743ec106834
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2019-11-06 06:23:00 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-11-06 06:23:22 +0000

    package.mask: unmask dev-go/delve (#694382)
    
    Bug: https://bugs.gentoo.org/694382
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/package.mask | 2 --
 1 file changed, 2 deletions(-)
Comment 6 g4s8.public 2019-11-06 10:32:03 UTC
This issue was fixed in delve/delve-1.3.0
Can we remove delve/delve-1.0.0 ebuild as outdated?
Comment 7 Joonas Niilola gentoo-dev 2019-11-06 14:08:24 UTC
(In reply to g4s8.public from comment #6)
> This issue was fixed in delve/delve-1.3.0
> Can we remove delve/delve-1.0.0 ebuild as outdated?

If nothing depends on it, 1.3.0 and 1.0.0 share same keywords and 1.3.0 works for everyone, yes.
Comment 8 Larry the Git Cow gentoo-dev 2019-11-07 05:42:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af3e54315025a71b812416ee61f984e5b64f21ef

commit af3e54315025a71b812416ee61f984e5b64f21ef
Author:     Kirill Che <g4s8.public@gmail.com>
AuthorDate: 2019-11-06 15:11:06 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-11-07 05:42:31 +0000

    dev-go/delve: yank version 1.0.0
    
    Closes: https://bugs.gentoo.org/694382
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Kirill Che <g4s8.public@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/13569
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-go/delve/Manifest           |  1 -
 dev-go/delve/delve-1.0.0.ebuild | 34 ----------------------------------
 2 files changed, 35 deletions(-)