Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693728 - net-wireless/crda: Support Python 3
Summary: net-wireless/crda: Support Python 3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2019-09-08 03:23 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2020-01-15 15:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (crda.patch,8.03 KB, patch)
2019-09-08 03:25 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-09-08 03:23:02 UTC
net-wireless/crda can be successfully built with Python 3 after applying simple patch for script used by build system.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-09-08 03:25:35 UTC
Created attachment 589386 [details, diff]
Patch
Comment 2 Dmitry Grigoriev 2019-11-18 00:20:14 UTC
There is also dependency chain: net-wireless/crda <--(depends on)-- dev-python/m2crypto <--- virtual/python-typing <--- dev-python/typing. All packages in this chain support python3 except dev-python/typing which has PYTHON_COMPAT=(python2_7 pypy). Which is weird. Or do I misunderstand something?
Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-11-18 17:25:41 UTC
(In reply to Dmitry Grigoriev from comment #2)
> Or do I misunderstand something?

Yes.

virtual/* packages exist only for abstracting dependencies so that given dependency string does not have to be copied to multiple packages and is only specified in given virtual/* package.

virtual/python-typing does NOT depend on dev-python/typing with any implementation of Python 3.
Python >=3.5 contains typing.py in standard library.
Comment 4 Dmitry Grigoriev 2019-11-18 17:37:23 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #3)

Thank you for explanation.
Comment 5 Mathy Vanvoorden 2019-11-29 13:01:00 UTC
Can confirm the patched ebuild works on a non-python2.7 system
Comment 6 Larry the Git Cow gentoo-dev 2020-01-15 14:44:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c50acec16bc7c33d6dc122c007d713e7fbecf9c

commit 9c50acec16bc7c33d6dc122c007d713e7fbecf9c
Author:     Vjaceslavs Klimovs <vklimovs@gmail.com>
AuthorDate: 2020-01-06 00:46:08 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2020-01-15 14:44:04 +0000

    net-wireless/crda: Bump to 4.14
    
    * Bump to 4.14 per availability from upstream
    * Support Python 3
    * Add patch to not compress docs
    
    Closes: https://bugs.gentoo.org/669076
    Closes: https://bugs.gentoo.org/693728
    Closes: https://bugs.gentoo.org/669578
    
    Signed-off-by: Vjaceslavs Klimovs <vklimovs@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/14254
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 net-wireless/crda/Manifest                         |   1 +
 net-wireless/crda/crda-3.18-r3.ebuild              |  14 +-
 net-wireless/crda/crda-4.14.ebuild                 |  84 ++++++
 .../crda/files/crda-4.14-do-not-compress-doc.patch |  36 +++
 .../crda-4.14-openssl-1.1.0-compatibility.patch    | 314 +++++++++++++++++++++
 net-wireless/crda/files/crda-4.14-python-3.patch   |  93 ++++++
 .../{crda-3.18-cflags.patch => crda-cflags.patch}  |   0
 ...{crda-3.18-ldflags.patch => crda-ldflags.patch} |   0
 ...18-libreg-link.patch => crda-libreg-link.patch} |   0
 ...rda-3.18-libressl.patch => crda-libressl.patch} |   0
 ...18-no-ldconfig.patch => crda-no-ldconfig.patch} |   0
 ...a-3.18-no-werror.patch => crda-no-werror.patch} |   0
 12 files changed, 535 insertions(+), 7 deletions(-)