The new aravis meson based ebuilds (release and live) have various issues; some new, some maybe old: * Is license really LGPL-2, not LGPL-2+? README says the latter at least. * gobject-introspection dep should use a subslot operator; better to >=1.54 too to be sure it works with meson (that's what I do, but not important, it's a very old version by now) * Unnecessary meson BDEPEND (eclass takes care of ensuring a newer minimum version than needed for aravis right now) * Wrong USE flag for gtk-doc, should be IUSE=gtk-doc. * Missing app-text/docbook-xml-dtd:4.3 BDEPEND when USE=gtk is enabled (should be USE=gtk-doc as per previous point). * Missing SLOT for dev-libs/glib dep * Missing SLOT for dev-libs/libxml2 dep; unnecessary subslot operator := dep * Unnecessary sys-libs/zlib subslot operator dep * Missing dev-util/glib-utils BDEPEND (gnome.mkenums_simple is called, requiring glib-mkenums utility from there) * Bad icons mangling hack. Fix meson.build instead and talk with upstream (or maybe just backport an existing fix for it or find the pending merge request or already reported issue). Additionally I question the choice of USE=X for building the simple viewer. The only dep on X is that it currently lacks the code to integrate with wayland - if gtk+ isn't built with USE=X, it'll fail at runtime. Thus at least gtk+[X] dep is missing (the USE flag) too for the time being; and in the future it'll probably be working with non-X gtk too. Consider a IUSE=gui or IUSE=viewer perhaps?
Thanks for the report Mart! I'm away until Monday, then I'll sit down to solve all of these :)
Some questions: > * gobject-introspection dep should use a subslot operator; better to >=1.54 too to be sure it works with meson (that's what I do, but not important, it's a very old version by now) I don't see any slots or subslots on `dev-libs/gobject-introspection`. Also, there are no versions <1.54 in the tree (lowest one is 1.56.1) > * Missing app-text/docbook-xml-dtd:4.3 BDEPEND when USE=gtk is enabled (should be USE=gtk-doc as per previous point). How did you verify that 4.3 is the right slot? (not doubting, just curious) > * Unnecessary sys-libs/zlib subslot operator dep Why unnecessary? It seems to me like that package is subslotted, even though only the 0/1 subslot is in the tree. ,
If gobject-introspection GIR format changes, we'll need to bump it and everything will need a rebuild. Most other things already subslot operator dep on gobject-introspection. It's not terribly important, as there are others that miss the subslot (some also because we don't define an explicit subslot for g-i) and it'll be a mess either way, should that ever happen. We hope it doesn't. docbook-xml-dtd dep I see from the xml or sgml file that the USE=gtk-doc stuff would consume; it has a header on top that says it's based on that. Because the build denies network access to that template, it needs to be installed on the system for the /etc/xml/ alias for it to kick and work without the network access. zlib subslot operator dep was wrongly added, QA even told to not do it upon review, but still was unfortunately done. Turning it back to not have it would cause all the rebuild pain again to the user, thus hasn't been done. So all we can do now is try to not make portage slower unnecessarily by adding the unnecessary subslot operator deps (having to deal with those is measurably one of the main reasons that portage has become slower over the years). Again, this is not a big problem, it just compounds on users, when hundred others packages do it too, as added seconds of dep resolution time. So out of these 3 things, just the docbook thing is what I can insist on getting fixed, other things are a bit more opinionated and required internal knowledge.
Alright, I rebased the PR, all fixes are up :)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54f7d30876ba90e10f0fa4ab68223e3bbe32e271 commit 54f7d30876ba90e10f0fa4ab68223e3bbe32e271 Author: Bernardo Meurer <bernardo@standard.ai> AuthorDate: 2019-09-12 00:21:19 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2019-09-19 06:42:39 +0000 media-video/aravis: multiple fixes Closes: https://bugs.gentoo.org/693700 Package-Manager: Portage-2.3.75, Repoman-2.3.17 Signed-off-by: Bernardo Meurer <bernardo@standard.ai> Closes: https://github.com/gentoo/gentoo/pull/12907 Signed-off-by: Michał Górny <mgorny@gentoo.org> media-video/aravis/aravis-0.6.4.ebuild | 29 ++++++++++++++++------------- media-video/aravis/aravis-9999.ebuild | 29 ++++++++++++++++------------- media-video/aravis/metadata.xml | 8 ++++---- 3 files changed, 36 insertions(+), 30 deletions(-)
