Bug 692524 – net-ftp/fspd - File Service Protocol server

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description hsn 2019-08-19 14:27:10 UTC]

Created attachment 587412 [details]
fspd-2.8.1-r1.ebuild

FSPD, UDP File transfer server

[Comment 1 Jeroen Roovers (RETIRED) 2019-08-22 08:36:12 UTC]

Comment on attachment 587412 [details]
fspd-2.8.1-r1.ebuild

># fspd Gentoo ebuild
># Created by 2019 Radim Kolar
># Public domain
>
>EAPI=7
>
>DESCRIPTION="FSP server"
>HOMEPAGE="https://fsp.sourceforge.net/"

That does not work for me with HTTPS, only with plain HTTP.

>FPV="${PV}b28"

You should put that in the version using patchlevel specifiers.

>FP="fsp-${FPV}"

Wouldn't you rather want to name the package "fsp"?

>SRC_URI="mirror://sourceforge/fsp/fsp/${FPV}/${FP}.tar.bz2"
>S=${WORKDIR}/${FP}
>
>LICENSE="MIT"
>SLOT="0"
>KEYWORDS="~amd64"
>IUSE=""
>
>DEPEND=""
>RDEPEND=""

There is no need to set three empty variables IUSE, DEPEND and RDEPEND.

>BDEPEND="sys-devel/flex"
>
>PYTHON_COMPAT=( python2_7 python3_6 )
>
>inherit python-any-r1 multilib scons-utils toolchain-funcs

PYTHON_COMPAT and the inherit should move to the top of the ebuild.

>src_configure() {
>		MYSCONS=(
>		    CC="$(tc-getCC)"
>		    prefix=${D}
>		    without-clients=yes
>			mandir=${D}/usr/share/man
>			docdir=${D}/usr/share/doc/${PF}
>			sysconfdir=/etc
>		)
>}

Too many levels of indentation.

Also, you might as well set the variable in src_compile() and skip the src_configure definition.

>src_compile() {
>		escons "${MYSCONS[@]}"
>}
>
>src_install() {
>		escons "${MYSCONS[@]}" install
>		rm -f ${D}/bin/fspscan ${D}/usr/share/man/man1/fspscan*

You should probably remove `-f` and add ` || die`. Also, why did you not want fspscan to be installed?

>		mkdir -p ${D}/etc
>		mv ${D}/share/examples/fsp/fspd.conf ${D}/etc
>		rm -rf ${D}/share
>}

[Comment 2 Jeroen Roovers (RETIRED) 2019-08-22 08:44:52 UTC]

(In reply to Jeroen Roovers from comment #1)
> Comment on attachment 587412 [details]
> fspd-2.8.1-r1.ebuild

> >FPV="${PV}b28"
> 
> You should put that in the version using patchlevel specifiers.

That is fspd-2.8_beta28.ebuild . Then in the ebuild, you replace "_beta" in ${PV} with "b", e.g.:

SRC_URI="mirror://sourceforge/fsp/fsp/${PV/_beta/b}/${P/_beta/b}.tar.bz2"

and everyone should be happy.

[Comment 3 hsn 2019-08-23 07:05:02 UTC]

fspscan is client side scanner. I am interested only in fspd since client side is difficult to use, it require to source shell script for operation.

[Comment 4 hsn 2019-08-23 08:09:07 UTC]

Created attachment 587814 [details]
New ebuild