692416 – sys-apps/tcp-wrappers-7.6.28[-ipv6]: scaffold.c:30:14: error: conflicting types for ‘malloc’

Bug 692416 - sys-apps/tcp-wrappers-7.6.28[-ipv6]: scaffold.c:30:14: error: conflicting types for ‘malloc’

Summary: sys-apps/tcp-wrappers-7.6.28[-ipv6]: scaffold.c:30:14: error: conflicting typ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal with 2 votes (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-08-18 05:54 UTC by email200202
Modified:	2019-08-30 22:34 UTC (History)
CC List:	10 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build.log (build.log,8.83 KB, text/x-log) 2019-08-18 05:54 UTC, email200202	Details
emerge -pqv '=sys-apps/tcp-wrappers-7.6.28::gentoo' (file_692416.txt,184 bytes, text/plain) 2019-08-18 05:56 UTC, email200202	Details
emerge --info '=sys-apps/tcp-wrappers-7.6.28::gentoo' (file_692416.txt,6.83 KB, text/plain) 2019-08-18 05:57 UTC, email200202	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description email200202 2019-08-18 05:54:37 UTC

Created attachment 587232 [details]
build.log

scaffold.c:30:14: error: conflicting types for ‘malloc’
   30 | extern char *malloc();
      |              ^~~~~~
In file included from scaffold.c:20:
/usr/include/stdlib.h:539:14: note: previous declaration of ‘malloc’ was here
  539 | extern void *malloc (size_t __size) __THROW __attribute_malloc__ __wur;
      |              ^~~~~~
make: *** [Makefile:686: scaffold.o] Error 1
make: *** Waiting for unfinished jobs....

Comment 1 email200202 2019-08-18 05:56:23 UTC

Created attachment 587234 [details]
emerge -pqv '=sys-apps/tcp-wrappers-7.6.28::gentoo'

Comment 2 email200202 2019-08-18 05:57:25 UTC

Created attachment 587236 [details]
emerge --info '=sys-apps/tcp-wrappers-7.6.28::gentoo'

Comment 3 Alexandru N. Barloiu 2019-08-19 10:02:27 UTC

Given that the previous declaration was in stdlib.h which is part of glibc I went with that one, and manually removed the second declaration from scaffold.c (which seemed to be only necessary for ipv6, and I had that disabled via use flag anyway) and the package compiled just fine.

Comment 4 mouac 2019-08-20 01:09:12 UTC

(In reply to Alexandru N. Barloiu from comment #3)
> Given that the previous declaration was in stdlib.h which is part of glibc I
> went with that one, and manually removed the second declaration from
> scaffold.c (which seemed to be only necessary for ipv6, and I had that
> disabled via use flag anyway) and the package compiled just fine.

The second declaration is actually for ipv4, but, likewise, I found that the stdlib.h declaration was sufficient.

Comment 5 Alexandru N. Barloiu 2019-08-20 01:15:51 UTC

sorry. my mistake.

Comment 6 Kajzer 2019-08-30 22:08:04 UTC

So, there is no one who can commit a fix for two weeks now?

Comment 7 Larry the Git Cow gentoo-dev

2019-08-30 22:34:11 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e219ad8be80cbe165b40781c2841c4d6eeb07c90

commit e219ad8be80cbe165b40781c2841c4d6eeb07c90
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-08-30 22:32:49 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-08-30 22:33:40 +0000

    sys-apps/tcp-wrappers: fix USE=-ipv6
    
    Closes: https://bugs.gentoo.org/692416
    Package-Manager: Portage-2.3.73, Repoman-2.3.17
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 .../files/tcp-wrappers-7.6.28-no-external-malloc.patch    | 15 +++++++++++++++
 sys-apps/tcp-wrappers/tcp-wrappers-7.6.28.ebuild          |  1 +
 2 files changed, 16 insertions(+)