Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692204 - >=sys-kernel/gentoo-sources-5.0 - add shiftfs support
Summary: >=sys-kernel/gentoo-sources-5.0 - add shiftfs support
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: https://github.com/linuxkit/linuxkit/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-15 10:28 UTC by fling
Modified: 2020-01-09 00:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description fling 2019-08-15 10:28:49 UTC
sys-kernel/gentoo-sources is missing shiftfs support

shiftfs support could be added with a masked use flag by patching gentoo-sources with diffs extracted from https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/eoan like this:

n=5001 ; for c in $(git log fs/shiftfs.c | grep ^commit | sed s/commit\ // | tac) ; do git format-patch -1 --start-number $n $c ; n=$(($n+1)) ; done
5001-UBUNTU-SAUCE-shiftfs-uid-gid-shifting-bind-mount.patch
5002-UBUNTU-SAUCE-shiftfs-rework-and-extend.patch
5003-UBUNTU-SAUCE-shiftfs-support-some-btrfs-ioctls.patch
5004-UBUNTU-SAUCE-shiftfs-use-translated-ids-when-chaning.patch
5005-UBUNTU-SAUCE-shiftfs-fix-passing-of-attrs-to-underal.patch
5006-UBUNTU-SAUCE-shiftfs-prevent-use-after-free-when-ver.patch
5007-UBUNTU-SAUCE-shiftfs-use-separate-llseek-method-for-.patch
5008-UBUNTU-SAUCE-shiftfs-lock-down-certain-superblock-fl.patch
5009-UBUNTU-SAUCE-shiftfs-allow-changing-ro-rw-for-subvol.patch

shiftfs works with linux 5.0, 5.1 and 5.2.
I tested these patches successfully with =sys-kernel/gentoo-sources-5.1.21.
Comment 1 Mike Pagano gentoo-dev 2019-08-16 18:04:41 UTC
I thinking this is a candidate for the 'experimental' use flag.
Comment 2 Mike Pagano gentoo-dev 2019-08-16 18:05:27 UTC
Can you test with 5.2, as 5.1 is EOL'd and 5.0 is long gone.
Comment 3 fling 2019-08-17 03:13:13 UTC
(In reply to Mike Pagano from comment #2)
> Can you test with 5.2, as 5.1 is EOL'd and 5.0 is long gone.

I extracted it from 5.2 repo btw.
Going to test the patches with 5.2 soon, waiting for the release of zfs 0.8.2 which adds 5.2 support.
Comment 4 fling 2019-08-24 06:51:28 UTC
Tested with 5.1 and lxd 3.16 from https://bugs.gentoo.org/show_bug.cgi?id=692198
Everything works as expected.
Comment 5 fling 2019-08-24 09:16:20 UTC
(In reply to Mike Pagano from comment #2)
> Can you test with 5.2, as 5.1 is EOL'd and 5.0 is long gone.

Tested with gentoo-sources-5.2.9, everything works as expected.
Comment 6 Mike Pagano gentoo-dev 2019-10-16 18:34:28 UTC
Sorry for slacking on this.

Would getting the patches from this git repo provide the support that is needed rather than from Ubuntu ?

https://github.com/linuxkit/linuxkit/tree/master/projects/shiftfs
Comment 7 Daniel Ziółkowski 2019-11-13 11:06:45 UTC
Ubuntu has more patches pertaining to shiftfs, the linuxkit repository might be rather outdated.

https://patchwork.ozlabs.org/project/ubuntu-kernel/list/?q=shiftfs
Comment 8 fling 2019-11-26 13:36:18 UTC
5.4 patches located at git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/unstable for now
Comment 9 Mike Pagano gentoo-dev 2020-01-09 00:09:45 UTC
(In reply to fling from comment #8)
> 5.4 patches located at
> git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/unstable
> for now

Is there something showing which patches are part of shitfs ?