Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691464 - net-analyzer/wireshark: incorrect usage of python-r1
Summary: net-analyzer/wireshark: incorrect usage of python-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-04 20:46 UTC by Michał Górny
Modified: 2019-09-20 07:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-08-04 20:46:25 UTC
The package uses python-r1.  However:

1. FWICS it does not have a runtime dep on Python.

2. It doesn't use any of the multi-implementation APIs.

This makes me believe the use of python-r1 is entirely incorrect.  If the package uses Python at build time only, python-any-r1 is the way to go.

As a side note, 'python3*' passed to python_setup is entirely redundant, given that no other Python version is supported by the ebuild.

See also:
https://qa-reports.gentoo.org/output/gentoo-ci/output.html#net-analyzer/wireshark
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-08-13 13:54:05 UTC
Ping.
Comment 2 Larry the Git Cow gentoo-dev 2019-08-14 05:47:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4bbab63820e27fabfcb521667850a01fd47254d8

commit 4bbab63820e27fabfcb521667850a01fd47254d8
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-08-14 05:39:40 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-08-14 05:47:52 +0000

    net-analyzer/wireshark: Inherit python-any-r1 instead of python-r1
    
    Package-Manager: Portage-2.3.71, Repoman-2.3.17
    Bug: https://bugs.gentoo.org/691464
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-analyzer/wireshark/wireshark-3.1.0.ebuild    | 5 ++---
 net-analyzer/wireshark/wireshark-99999999.ebuild | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-09-20 07:34:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5aa3bedbdb5bc10fde05d5fe714c9362aaa585b

commit a5aa3bedbdb5bc10fde05d5fe714c9362aaa585b
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-09-20 06:57:57 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-09-20 07:34:44 +0000

    net-analyzer/wireshark: [QA] Silence PYTHON_DEPS warning in old ver
    
    Move PYTHON_DEPS to RDEPEND to match eclass used in 3.0*.  This is going
    to silence the CI report, finally making it possible to turn it into
    proper warning, and the proper fix will land in its time via 3.1.0.
    
    Closes: https://bugs.gentoo.org/691464
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-analyzer/wireshark/wireshark-3.0.3.ebuild | 2 +-
 net-analyzer/wireshark/wireshark-3.0.4.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)