Created attachment 584988 [details, diff] Patch with fix As outlined in bug #678090 and bug #690190, the Emacs mode has been split to a separate package. I have already filed a bug report for said new package (bug #690996). This fixes app-office/ledger to depend on that with USE=emacs.
(In reply to Thomas Schneider from comment #0) > Created attachment 584988 [details, diff] [details, diff] > Patch with fix <Emacs team> Patch looks good to me. (ledger-3.1.2 no longer installs any Emacs mode, so no changes to the upstream build system are necessary.) </Emacs team>
Is it customary to provide this emacs mode via USE flag? Otherwise I don't see the need for this to be in the ledger ebuild (ugly optional runtime depend).
(In reply to Andreas Sturmlechner from comment #2) > Is it customary to provide this emacs mode via USE flag? Otherwise I don't > see the need for this to be in the ledger ebuild (ugly optional runtime > depend). We have several packages doing that, e.g. sys-devel/autoconf or sys-devel/gettext. Their Emacs mode is built from the same tarball, and has been split off into its own (Gentoo) package to avoid circular dependencies. Here the situation is somewhat different, because the split-off has taken place upstream. So thinking about it again, omitting the PDEPEND may be cleaner indeed.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3806c0fefbf35e780bef077eda75e4c1ae054000 commit 3806c0fefbf35e780bef077eda75e4c1ae054000 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-08-10 22:47:56 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-08-11 08:19:24 +0000 app-office/ledger: Drop elisp-common, make reference in pkg_postinst Non-maintainer commit. Drop duplicate eapply-user that is already run by cmake-utils. Closes: https://bugs.gentoo.org/691004 Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> app-office/ledger/ledger-3.1.2.ebuild | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-)
