Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690038 - app-crypt/eid-mw-4.4.19 version bump
Summary: app-crypt/eid-mw-4.4.19 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vincent Hardy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-17 02:04 UTC by Didier Cardoso
Modified: 2019-08-15 19:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
eid-mw-4.4.19.ebuild (eid-mw-4.4.19.ebuild,2.23 KB, text/plain)
2019-07-17 02:04 UTC, Didier Cardoso
Details
eid-mw-4.4.19.ebuild (eid-mw-4.4.19.ebuild,2.31 KB, text/plain)
2019-07-29 17:36 UTC, Vincent Hardy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Cardoso 2019-07-17 02:04:22 UTC
Created attachment 583162 [details]
eid-mw-4.4.19.ebuild

New version of eID middleware supplied by the Belgian Federal Government
(released on July 16, 2019)

I had to add a sed to correct the destination folder of the Mozilla's pkcs11 modules (/usr/lib/mozilla was hardcoded).

Reproducible: Always
Comment 1 Jonas Stein gentoo-dev 2019-07-20 17:17:16 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman
* We always try to use the latest EAPI, please bump to EAPI=7
* || die is missing for example behind the sed lines 
* A bot can look for additional mistakes, if you upload a PR via github (will then get faster in the tree too)
Comment 2 Vincent Hardy 2019-07-29 17:36:27 UTC
Created attachment 584992 [details]
eid-mw-4.4.19.ebuild

Hi all,

@Jonas,
I am the proxy-maintainer of eid-mw.
In attachment, you will find my version of the new ebuild.
If it is good enough for you, can you commit it to the portage tree.
At the same time, can you remove eid-mw-4.4.1 (no need to keep it).
Thanks in advance.

@Didier,
Thank you for pointing out this libdir issue.
Comment 3 Vincent Hardy 2019-08-15 08:18:51 UTC
Comment on attachment 584992 [details]
eid-mw-4.4.19.ebuild

I try to contact Amy and I send her a new ebuild that fixes both this bug and bug #691308.
Comment 4 Larry the Git Cow gentoo-dev 2019-08-15 19:20:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2c4faef071d1e2210ea330d5f14f1fe80403527

commit e2c4faef071d1e2210ea330d5f14f1fe80403527
Author:     Amy Liffey <amynka@gentoo.org>
AuthorDate: 2019-08-15 19:14:35 +0000
Commit:     Amy Liffey <amynka@gentoo.org>
CommitDate: 2019-08-15 19:19:35 +0000

    app-crypt/eid-mw: version bump 4.4.19
    
    Closes: https://bugs.gentoo.org/690038
    Submitted-by: Vincent Hardy <vincent.hardy.be@gmail.com>
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Amy Liffey <amynka@gentoo.org>

 app-crypt/eid-mw/Manifest                         |   1 +
 app-crypt/eid-mw/eid-mw-4.4.19.ebuild             | 103 ++++++++
 app-crypt/eid-mw/files/eid-sign-test-4.4.19.patch | 272 ++++++++++++++++++++++
 3 files changed, 376 insertions(+)