Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689680 - app-admin/keepassxc-2.4.3 lack of wayland flag / depend on dev-qt/qtwayland on native wayland desktop
Summary: app-admin/keepassxc-2.4.3 lack of wayland flag / depend on dev-qt/qtwayland o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: https://wiki.qt.io/QtWayland#Run_Qt_a...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-11 19:01 UTC by salmander
Modified: 2019-08-08 22:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description salmander 2019-07-11 19:01:33 UTC
amd64~

[ebuild   R    ] app-admin/keepassxc-2.4.3 USE="-autotype -browser -debug -keeshare -network -test -yubikey"

Won't launch on native wayland display with QT_QPA_PLATFORM=wayland.

It depend on: dev-qt/qtwayland.

I create custom ebuild and it would be great to have a wayland flag.

diff /usr/portage/app-admin/keepassxc/keepassxc-2.4.3.ebuild keepassxc-2.4.3-r1.ebuild 
27c27
< IUSE="autotype browser debug keeshare +network test yubikey"
---
> IUSE="autotype browser debug keeshare +network test yubikey wayland"
50a51
> 	wayland? ( >=dev-qt/qtwayland-5.12.4 )



Reproducible: Always
Comment 1 Andreas Sturmlechner gentoo-dev 2019-07-12 19:49:58 UTC
So far, the only package depending on dev-qt/qtwayland is kde-frameworks/kwayland where it is an RDEPEND. Individual applications shouldn't have to depend on qtwayland when they aren't running with KWin as compositor.

CCing qt-proj: qguiapplication.cpp from dev-qt/qtgui contains the code to check for desktop and session type, QT_QPA_PLATFORM variable etc. Should we make sure from there to pull in dev-qt/qtwayland somehow?
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2019-07-13 05:25:27 UTC
Adding a USE=wayland in qtgui that pulls in qtwayland as PDEPEND would be acceptable to me. OTOH, this is a user error, the documentation makes it clear that you must install QtWayland, so closing as INVALID/WONTFIX is equally acceptable.
Comment 3 Andreas Sturmlechner gentoo-dev 2019-07-13 09:47:41 UTC
You're right it's even mentioned in Gentoo Wayland Wiki: https://wiki.gentoo.org/wiki/Wayland#Qt

However, I think we can't expect every user to install needed runtime bits for Wayland per Toolkit on their own, so conditional PDEPEND imo is the best course of action.
Comment 4 Larry the Git Cow gentoo-dev 2019-07-21 16:13:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85f94f296fb77f8a125c41702155ca3581f47171

commit 85f94f296fb77f8a125c41702155ca3581f47171
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-07-21 15:45:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-07-21 16:13:21 +0000

    dev-qt/qtgui: Add USE wayland
    
    Closes: https://bugs.gentoo.org/689680
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgui/metadata.xml        | 1 +
 dev-qt/qtgui/qtgui-5.12.4.ebuild | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2019-08-08 22:21:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=8a3fd32a97e417da1af359471509dfa10877402b

commit 8a3fd32a97e417da1af359471509dfa10877402b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-07-21 15:45:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-08-08 11:45:31 +0000

    dev-qt/qtgui: Add USE wayland
    
    Closes: https://bugs.gentoo.org/689680
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgui/metadata.xml           | 1 +
 dev-qt/qtgui/qtgui-5.12.9999.ebuild | 3 ++-
 dev-qt/qtgui/qtgui-5.13.9999.ebuild | 3 ++-
 dev-qt/qtgui/qtgui-5.9999.ebuild    | 3 ++-
 4 files changed, 7 insertions(+), 3 deletions(-)