Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689196 - media-video/aegisub-3.2.2_p20160518-r2 does not build against dev-libs/boost-1.70.0
Summary: media-video/aegisub-3.2.2_p20160518-r2 does not build against dev-libs/boost-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nick Sarnie
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: boost-1.71
  Show dependency tree
 
Reported: 2019-07-03 10:51 UTC by Damien Thébault
Modified: 2019-07-12 01:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,250.51 KB, text/x-log)
2019-07-03 10:54 UTC, Damien Thébault
Details
emerge --info (emerge--info.txt,7.67 KB, text/plain)
2019-07-03 10:55 UTC, Damien Thébault
Details
Working patch with portage (aegisub-3.2.2_p20160518-boost-1.69.patch,1.91 KB, patch)
2019-07-03 10:56 UTC, Damien Thébault
Details | Diff
Patch working for both versions of boost (aegisub-boost-1.68-1.69.patch,1.45 KB, patch)
2019-07-10 11:34 UTC, Damien Thébault
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Damien Thébault 2019-07-03 10:51:16 UTC
aegisub-3.2.2 does not build against boost-1.70 because of the following error:

  colour_button.cpp:21:10: fatal error: boost/gil/gil_all.hpp: No such file or directory
   #include <boost/gil/gil_all.hpp>

The issue was reported on aegisub github in October 2018 and has been fixed in master:
https://github.com/Aegisub/Aegisub/issues/93

Void linux has a patch for this issue:
https://github.com/void-linux/void-packages/blob/master/srcpkgs/Aegisub/patches/boost-1.69.patch

I've tested with the patch in /etc/portage/patches (modified it to add a/ and b/ prefixes for it to apply), and it builds fine against boot 1.70.

Reproducible: Always
Comment 1 Damien Thébault 2019-07-03 10:54:43 UTC
Created attachment 581842 [details]
build.log
Comment 2 Damien Thébault 2019-07-03 10:55:05 UTC
Created attachment 581844 [details]
emerge --info
Comment 3 Damien Thébault 2019-07-03 10:56:48 UTC
Created attachment 581846 [details, diff]
Working patch with portage
Comment 4 Ștefan Talpalaru 2019-07-06 18:00:22 UTC
Patched versions added to my overlay: https://github.com/stefantalpalaru/gentoo-overlay
Comment 5 Nick Sarnie gentoo-dev 2019-07-08 22:36:46 UTC
The patch should handle older boost versions too, it looks like it would make build with <1.70.0 fail. Can you address that?

Thanks,
Sarnex
Comment 6 Damien Thébault 2019-07-10 11:34:56 UTC
Created attachment 582358 [details, diff]
Patch working for both versions of boost
Comment 7 Larry the Git Cow gentoo-dev 2019-07-12 01:43:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=01c90376343b3883da48f42accbbf0a6de4193e2

commit 01c90376343b3883da48f42accbbf0a6de4193e2
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2019-07-12 01:36:13 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2019-07-12 01:43:15 +0000

    media-video/aegisub: Fix build against boost 1.70.0
    
    Patch from: Damien Thébault <damien.thebault@gmail.com>
    
    Fixes: https://bugs.gentoo.org/689196
    
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 .../aegisub/aegisub-3.2.2_p20160518-r3.ebuild      | 148 +++++++++++++++++++++
 media-video/aegisub/aegisub-9999.ebuild            |   1 +
 ...egisub-3.2.2_p20160518-fix-boost170-build.patch |  61 +++++++++
 3 files changed, 210 insertions(+)